You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/03/21 17:34:45 UTC
[GitHub] flink pull request: Adds akka interal docs and configuration descr...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/512
Adds akka interal docs and configuration description
Adds Akka documentation and configuration description to docs. The Akka internal documentation is the same as the one published in the wiki at the moment of opening this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink akkaDocumentation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #512
----
commit 2e83f69c24efcf42ac52758cd446237baa3263ad
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-02-19T17:01:42Z
[docs] Adds akka interal docs and configuration description
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Adds akka interal docs and configuration descr...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/512#issuecomment-84447837
+1 to keep it in Wiki for now. There is already a stub in the Doc so we could just set it to point to the wiki
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Adds akka interal docs and configuration descr...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/512
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Adds akka interal docs and configuration descr...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/512#issuecomment-84940008
Yes I agree that we should keep the internals only at one place. Even then, it is probably hard enough to keep the docs in sync with the code.
But what still might be interesting to add to the docs is the description of the configuration parameters. There is still a big hole under "Distributed coordination (via Akka)".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Adds akka interal docs and configuration descr...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/512#issuecomment-84423710
Looks good. This is basically a copy of the Wiki, right?
How about we keep the docs in one place only. Otherwise, they are almost sure to get out of sync.
We can
- move them to the git repo later (in a batch, when we have more components)
- Keep them in the wiki and have in the git repo a few pages that link to the wiki. For the detail internals (actors, memory, network stack), we can have on overview page in the docs and link to the wiki from there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Adds akka interal docs and configuration descr...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/512#issuecomment-85245168
Ok, I'll close this PR and open a new one only containing the respective configuration documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Adds akka interal docs and configuration descr...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/512#issuecomment-85169924
+1 for updating the configuration guide with the Akka variables.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---