You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/11/27 20:05:37 UTC
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8648
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
[DOCS] Include the current Impala version number on PDF title page
To make it easier when someone has downloaded the PDF, or is
republishing a new release of docs, to doublecheck that they
are looking at the latest version. Otherwise, this information
is only available by looking through the PDF for new information
or by checking what the latest subtopic is under "Fixed Issues"
or "New Features".
Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/8648/1
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
Patch Set 1:
I wonder though do we need the ability to let the docs run at a slightly different schedule than the code. For example, today or tomorrow I want to republish the 2.10 docs to account for the removal of "incubating". Regardless of whether some part of the code in master is labelled with a version number of 2.11.
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 21:15:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8648/1/docs/impala_keydefs.ditamap
File docs/impala_keydefs.ditamap:
http://gerrit.cloudera.org:8080/#/c/8648/1/docs/impala_keydefs.ditamap@10521
PS1, Line 10521: <!-- Note: needs to be updated once for each Impala release. -->
: <keydef keys="impala_current_version"><topicmeta><keywords><keyword>2.10</keyword></keywords></topicmeta></keydef>
I respect your desire to fix this, but there is a maintenance cost in doing this: someone has to remember to set this version. Note that bin/save-version.sh is the canonical place the Impala version is set. When we have it in two places, people don't always update both places. I'm working on seeing if I can incorporate a bin/save-version.sh call into the docs build.
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 21:00:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
Patch Set 1: Code-Review+1
Built the PDF and it looks okay.
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 20:57:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
Patch Set 1:
> My understanding is that you think this commit would only make the
> problem easier to pretend does not exist. Is that right?
You worded it better than I did. Yes, that's exactly it.
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 16:07:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
Patch Set 1:
Here is my approach to this problem: https://gerrit.cloudera.org/#/c/8654/
Btw, I'm perfectly willing to entertain the notion that this should be accepted, but I'd like us also to be forward-thinking about being able to release docs along with code. Feel free to continue the discussion here, or on the dev@ list.
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 23:26:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
Patch Set 1:
> I would prefer the docs to be ready for release alongside the code,
> not after.
I would prefer that, too, but I'm not sure how to get there from here. I interpret "here" as "John contributes 81% of patches that touch the docs/ directory; code commits that require docs changes rarely have docs changes in them."
My understanding is that you think this commit would only make the problem easier to pretend does not exist. Is that right?
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 04:48:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
Patch Set 1:
> Also, why publish 2.10 docs updates from master in the first place?
> Shouldn't that come from a branch off branch-2.10? (I can imagine
> sometimes that this is necessary: correcting errata, for instance.)
Changes to the release branches are done directly right now, without gerrit review. That could probably be fixed by adding a gerrit branch, like was done with asf-site.
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 00:50:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has abandoned this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 )
Change subject: [DOCS] Include the current Impala version number on PDF title page
......................................................................
Patch Set 1:
> I wonder though do we need the ability to let the docs run at a
> slightly different schedule than the code.
I would prefer the docs to be ready for release alongside the code, not after. I don't agree with continually punting on releasing docs on time. Mechanisms like "allow us to make updates to 2.10 docs from master" help ensure that docs may always run late.
> For example, today or tomorrow I want to republish the 2.10 docs to account for the removal of "incubating".
Why? 2.10 was released weeks ago, when Impala was still incubating.
Also, why publish 2.10 docs updates from master in the first place? Shouldn't that come from a branch off branch-2.10? (I can imagine sometimes that this is necessary: correcting errata, for instance.)
--
To view, visit http://gerrit.cloudera.org:8080/8648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2
Gerrit-Change-Number: 8648
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 21:44:07 +0000
Gerrit-HasComments: No