[GitHub] [skywalking] xuanyu66 edited a comment on pull request #6567: fix no trace id in async log

[GitBox <gi...@apache.org>]

xuanyu66 edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803718551


   > @xuanyu66
   > I've read your issue and code, but I still don't quite understand the reason for the bug, can you describe your usage scenario? Because it works fine with the following configuration
   > 
   > ```
   > <Configuration>
   >         <Appenders>
   >             <Console name="_Console" target="SYSTEM_OUT">
   >                 <PatternLayout pattern="%d [%traceId] %-5p %c{1}:%L - %m%n"/>
   >             </Console>
   >             <Async name="Console">
   >                 <AppenderRef ref="_Console"/>
   >             </Async>
   >         </Appenders>
   >         <Loggers>
   >             <Root level="INFO">
   >                 <Appender-Ref ref="Console"/>
   >             </Root>
   >         </Loggers>
   > </Configuration>
   > ```
   ```
   Configuration:
     properties:
       property:
         - name: logPath
           value: XXXX
         - name: filename
           value: XXXX
         - name: pattern
           value: "XXXXX"
         - name: httpRequestPattern
           value: "XXXXXX"
   
     status: "info"
     Appenders:
       RollingRandomAccessFile:
         - name: "FileAppender"
           fileName: "${logPath}${filename}"
           filePattern: "${logPath}${filename}.%d{yyyy-MM-dd}"
           PatternLayout:
             pattern: "${pattern}"
           Policies:
             TimeBasedTriggeringPolicy: {}
           immediateFlush: false
         - name: "AnalysisFileAppender"
           fileName: "${logPath}analysis-${filename}"
           filePattern: "${logPath}analysis-${filename}.%d{yyyy-MM-dd}"
           PatternLayout:
             pattern: "${pattern}"
           Policies:
             TimeBasedTriggeringPolicy: {}
           immediateFlush: false
         - name: "HTTPRequestFileAppender"
           fileName: "${logPath}http-request-${filename}"
           filePattern: "${logPath}http-request-${filename}.%d{yyyy-MM-dd}"
           PatternLayout:
             pattern: "${httpRequestPattern}"
           Policies:
             TimeBasedTriggeringPolicy: {}
           immediateFlush: false
         - name: "RPCRequestFileAppender"
           fileName: "${logPath}rpc-request-${filename}"
           filePattern: "${logPath}rpc-request-${filename}.%d{yyyy-MM-dd}"
           PatternLayout:
             pattern: "${pattern}"
           Policies:
             TimeBasedTriggeringPolicy: {}
           immediateFlush: false
       Async:
         - name: "AsyncFileAppender"
           AppenderRef:
             - ref: FileAppender
           bufferSize: 10000
         - name: "AsyncAnalysisFileAppender"
           AppenderRef:
             - ref: AnalysisFileAppender
           bufferSize: 15000
         - name: "AsyncHTTPRequestFileAppender"
           AppenderRef:
             - ref: HTTPRequestFileAppender
           bufferSize: 10000
         - name: "AsyncRPCRequestFileAppender"
           AppenderRef:
             - ref: RPCRequestFileAppender
           bufferSize: 10000
   
     Loggers:
       AsyncLogger:
         - name: "RequestLogger"
           level: info
           additivity: false
           AppenderRef:
             - ref: AsyncHTTPRequestFileAppender
         - name: "RpcRequestLogger"
           level: info
           additivity: false
           AppenderRef:
             - ref: AsyncRPCRequestFileAppender
         - name: "AnalysisLogger"
           level: info
           additivity: false
           AppenderRef:
             - ref: AsyncAnalysisFileAppender
       AsyncRoot:
         level: info
         AppenderRef:
           - ref: AsyncFileAppender
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org