You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2025/04/16 07:17:37 UTC
[PR] improve: Resolve hostname only when useHostNameAsBookieID is enabled [bookkeeper]
nodece opened a new pull request, #4583:
URL: https://github.com/apache/bookkeeper/pull/4583
### Motivation
The existing implementation always resolves the default hostname for the specified network interface, even when `useHostNameAsBookieID` is disabled. This is unnecessary and can introduce resolution failures or delays in environments where DNS is misconfigured or unavailable.
Restricting hostname resolution to only when `useHostNameAsBookieID` is enabled improves efficiency and avoids potential issues related to unnecessary hostname lookups.
### Changes
- Moved hostname resolution logic under the `useHostNameAsBookieID` condition.
- When `useHostNameAsBookieID` is false, the code now directly uses `DNS.getDefaultIP(iface)` to obtain the IP address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improve: Resolve hostname only when useHostNameAsBookieID is enabled [bookkeeper]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #4583:
URL: https://github.com/apache/bookkeeper/pull/4583#issuecomment-2809894711
Alternative: #4588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] improve: Resolve hostname only when useHostNameAsBookieID is enabled [bookkeeper]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece closed pull request #4583: improve: Resolve hostname only when useHostNameAsBookieID is enabled
URL: https://github.com/apache/bookkeeper/pull/4583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org