You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2025/04/17 23:10:59 UTC

(royale-asjs) branch develop updated (7138dcc00f -> a76f7fb8f7)

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


    from 7138dcc00f ASDoc: inheritance list scrolls horizontally if it gets too large
     new 1e56344734 ASDoc: resize app when browser resizes, and don't let body scroll
     new 69b101805a RoyaleSite: make the top bar layout match the real site a bit better
     new 5f2a1a2dbf ASDoc: fix issue where content was too big for body due to bad measurements from margin and flex-wrap
     new c071c6fdcf ASDoc: add ASDocInterface for JSONReviver
     new a57891fa57 ASDocModel: add ioError listeners and recovery from certain errors
     new 8ff67d79ef ASDoc: sanitize HTML for class description
     new 2e77089864 ASDoc: detail renderers display descriptions as HTML and sanitize it
     new a76f7fb8f7 ASDoc: stricter builds

The 8 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 examples/royale/ASDoc/build.xml                    |   2 -
 examples/royale/ASDoc/src/main/royale/ASDoc.mxml   |   5 +
 .../royale/ASDoc/src/main/royale/ASDocInterface.as |  14 +-
 .../ASDoc/src/main/royale/ASDocMainView.mxml       |  13 +-
 .../ASDoc/src/main/royale/EventDetailRenderer.mxml |   4 +-
 .../src/main/royale/MethodDetailRenderer.mxml      |   4 +-
 .../src/main/royale/PropertyDetailRenderer.mxml    |   4 +-
 .../ASDoc/src/main/royale/models/ASDocModel.as     | 159 ++++++++++++++-------
 .../RoyaleSite/src/main/resources/defaults.css     |  29 ++--
 .../royale/org/apache/royale/site/DocTopBar.mxml   |   1 -
 10 files changed, 154 insertions(+), 81 deletions(-)
 copy frameworks/projects/HTML/src/main/royale/HTMLClasses.as => examples/royale/ASDoc/src/main/royale/ASDocInterface.as (81%)


(royale-asjs) 01/08: ASDoc: resize app when browser resizes, and don't let body scroll

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 1e56344734a84ea1fe25d5e95d9f53e65fb2bc92
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 17 11:52:38 2025 -0700

    ASDoc: resize app when browser resizes, and don't let body scroll
    
    Individual containers should scroll
---
 examples/royale/ASDoc/src/main/royale/ASDoc.mxml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/examples/royale/ASDoc/src/main/royale/ASDoc.mxml b/examples/royale/ASDoc/src/main/royale/ASDoc.mxml
index 17b6cfecbd..7a0affe3af 100644
--- a/examples/royale/ASDoc/src/main/royale/ASDoc.mxml
+++ b/examples/royale/ASDoc/src/main/royale/ASDoc.mxml
@@ -35,6 +35,10 @@ limitations under the License.
             verticalAlign: bottom;
         }
 
+        body {
+            overflow: hidden;
+        }
+
         pre {
             overflow: auto;
         }
@@ -56,5 +60,6 @@ limitations under the License.
         </js:HTTPService>
         <js:JSONReviver id="reviver" />
         <js:ViewSourceContextMenuOption />
+        <js:BrowserResizeApplicationListener enableScroll="false"/>
     </js:beads>
 </js:Application>


(royale-asjs) 07/08: ASDoc: detail renderers display descriptions as HTML and sanitize it

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 2e77089864c8fdf0e6d39a32fcb4c39cbd8259da
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 17 15:55:40 2025 -0700

    ASDoc: detail renderers display descriptions as HTML and sanitize it
---
 examples/royale/ASDoc/src/main/royale/EventDetailRenderer.mxml    | 4 +++-
 examples/royale/ASDoc/src/main/royale/MethodDetailRenderer.mxml   | 4 +++-
 examples/royale/ASDoc/src/main/royale/PropertyDetailRenderer.mxml | 4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/examples/royale/ASDoc/src/main/royale/EventDetailRenderer.mxml b/examples/royale/ASDoc/src/main/royale/EventDetailRenderer.mxml
index 887d9fcf03..8cc5f554f0 100644
--- a/examples/royale/ASDoc/src/main/royale/EventDetailRenderer.mxml
+++ b/examples/royale/ASDoc/src/main/royale/EventDetailRenderer.mxml
@@ -24,6 +24,8 @@ limitations under the License.
                      width="100%">
     <fx:Script>
         <![CDATA[
+			import org.apache.royale.utils.string.sanitizeHtml;
+
             
 			override public function set data(value:Object):void
 			{
@@ -80,5 +82,5 @@ limitations under the License.
         <models:ListPresentationModel rowHeight="NaN"/>
       </js:beads>
     </js:DataContainer>
-    <js:MultilineLabel id="description" width="100%" text="{obj.description}"/>
+    <js:MultilineLabel id="description" width="100%" html="{sanitizeHtml(obj.description)}"/>
 </js:MXMLItemRenderer>
diff --git a/examples/royale/ASDoc/src/main/royale/MethodDetailRenderer.mxml b/examples/royale/ASDoc/src/main/royale/MethodDetailRenderer.mxml
index 6bf1386a8a..8b6aed9536 100644
--- a/examples/royale/ASDoc/src/main/royale/MethodDetailRenderer.mxml
+++ b/examples/royale/ASDoc/src/main/royale/MethodDetailRenderer.mxml
@@ -24,6 +24,8 @@ limitations under the License.
                      width="100%">
     <fx:Script>
         <![CDATA[            
+            import org.apache.royale.utils.string.sanitizeHtml;
+
             private static var fakeBothPlatforms:Object = {"addEventListener": 1, "removeEventListener" : 1,
                 "hasEventListener": 1, "dispatchEvent": 1,
                 "toString": 1};
@@ -92,5 +94,5 @@ limitations under the License.
         <models:ListPresentationModel rowHeight="NaN"/>
       </js:beads>
     </js:DataContainer>
-    <js:MultilineLabel id="description" width="100%" text="{obj.description}"/>
+    <js:MultilineLabel id="description" width="100%" html="{sanitizeHtml(obj.description)}"/>
 </js:MXMLItemRenderer>
diff --git a/examples/royale/ASDoc/src/main/royale/PropertyDetailRenderer.mxml b/examples/royale/ASDoc/src/main/royale/PropertyDetailRenderer.mxml
index 2e45ffc0b2..ee42274045 100644
--- a/examples/royale/ASDoc/src/main/royale/PropertyDetailRenderer.mxml
+++ b/examples/royale/ASDoc/src/main/royale/PropertyDetailRenderer.mxml
@@ -24,6 +24,8 @@ limitations under the License.
                      width="100%">
     <fx:Script>
         <![CDATA[
+			import org.apache.royale.utils.string.sanitizeHtml;
+
 			override public function set data(value:Object):void
 			{
 				super.data = value;
@@ -80,5 +82,5 @@ limitations under the License.
         <models:ListPresentationModel rowHeight="NaN"/>
       </js:beads>
     </js:DataContainer>
-    <js:MultilineLabel id="description" width="100%" text="{obj.description}"/>
+    <js:MultilineLabel id="description" width="100%" html="{sanitizeHtml(obj.description)}"/>
 </js:MXMLItemRenderer>


(royale-asjs) 05/08: ASDocModel: add ioError listeners and recovery from certain errors

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit a57891fa5778a97cecc60b171dac14cc1498c167
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 17 15:33:51 2025 -0700

    ASDocModel: add ioError listeners and recovery from certain errors
---
 .../ASDoc/src/main/royale/models/ASDocModel.as     | 154 ++++++++++++++-------
 1 file changed, 106 insertions(+), 48 deletions(-)

diff --git a/examples/royale/ASDoc/src/main/royale/models/ASDocModel.as b/examples/royale/ASDoc/src/main/royale/models/ASDocModel.as
index 9a75d9e9b5..53e8de1399 100644
--- a/examples/royale/ASDoc/src/main/royale/models/ASDocModel.as
+++ b/examples/royale/ASDoc/src/main/royale/models/ASDocModel.as
@@ -42,6 +42,7 @@ package models
         
         private function initializeHandler(event:Event):void
         {
+            app.service.addEventListener("ioError", configIOErrorHandler);
             app.service.addEventListener("complete", configCompleteHandler);
             app.service.url = "config.json";
             app.service.send();
@@ -70,9 +71,18 @@ package models
         
         private var platformList:Array;
         private var currentPlatform:String;
+
+        private function configIOErrorHandler(event:Event):void
+        {
+            app.service.removeEventListener("ioError", configIOErrorHandler);
+            app.service.removeEventListener("complete", configCompleteHandler);
+
+            trace("[ASDoc] failed to load URL: " + app.service.url);
+        }
         
         private function configCompleteHandler(event:Event):void
         {
+            app.service.removeEventListener("ioError", configIOErrorHandler);
             app.service.removeEventListener("complete", configCompleteHandler);
             var config:Object = JSON.parse(app.service.data);
             tagNameMap = config["tagNames"];
@@ -116,7 +126,7 @@ package models
                 platformList = platforms.slice();
                 currentPlatform = platformList.shift();
                 middle = "." + currentPlatform;
-                app.service.addEventListener("complete", completeHandler);
+                app.service.addEventListener("complete", classListCompleteHandler);
                 app.service.url = "classlist" + middle + ".json";
                 app.service.send();                
             }
@@ -132,9 +142,9 @@ package models
         /**
          * @royaleignorecoercion ASDocClassData 
          */
-        private function completeHandler(event:Event):void
+        private function classListCompleteHandler(event:Event):void
         {
-            app.service.removeEventListener("complete", completeHandler);
+            app.service.removeEventListener("complete", classListCompleteHandler);
             if (!masterData)
                 masterData = { "classnames": [], "data": [] };
             var allNames:Array = allClasses;
@@ -162,27 +172,55 @@ package models
             {
                 currentPlatform = platformList.shift();
                 var middle:String = "." + currentPlatform;
-                app.service.addEventListener("complete", completeHandler);
+                app.service.addEventListener("complete", classListCompleteHandler);
                 app.service.url = "classlist" + middle + ".json";
                 app.service.send();
             }
             else
             {
-                filterPackageList();
                 platformList = platforms.slice();
                 currentPlatform = platformList.shift();
                 middle = "." + currentPlatform;
+                app.service.addEventListener("ioError", classesIOErrorHandler);
                 app.service.addEventListener("complete", classesCompleteHandler);
                 app.service.url = "classes" + middle + ".json";
                 app.service.send();                
             }
         }
+
+        private function loadClassesForNextPlatform():void
+        {
+            if (platformList.length)
+            {
+                currentPlatform = platformList.shift();
+                var middle:String = "." + currentPlatform;
+                app.service.addEventListener("ioError", classesIOErrorHandler);
+                app.service.addEventListener("complete", classesCompleteHandler);
+                app.service.url = "classes" + middle + ".json";
+                app.service.send();
+            }
+            else
+            {
+                filterPackageList();
+            }
+        }
+
+        private function classesIOErrorHandler(event:Event):void
+        {
+            app.service.removeEventListener("ioError", classesIOErrorHandler);
+            app.service.removeEventListener("complete", classesCompleteHandler);
+
+            trace("[ASDoc] failed to load URL: " + app.service.url);
+
+            loadClassesForNextPlatform();
+        }
         
         /**
          * @royaleignorecoercion ASDocClass 
          */
         private function classesCompleteHandler(event:Event):void
         {
+            app.service.removeEventListener("ioError", classesIOErrorHandler);
             app.service.removeEventListener("complete", classesCompleteHandler);
             if (!masterData["filterData"])
                 masterData["filterData"] = {};
@@ -208,14 +246,7 @@ package models
                     masterData["filterData"][cname] = item;
                 }
             }
-            if (platformList.length)
-            {
-                currentPlatform = platformList.shift();
-                var middle:String = "." + currentPlatform;
-                app.service.addEventListener("complete", classesCompleteHandler);
-                app.service.url = "classes" + middle + ".json";
-                app.service.send();
-            }
+            loadClassesForNextPlatform();
         }
         
         private function addTags(item:ASDocClass, tags:Array):void
@@ -343,7 +374,8 @@ package models
                 dispatchEvent(new Event("currentClassChanged"));
                 platformList = platforms.slice();
                 currentPlatform = platformList.shift();
-                app.service.addEventListener("complete", completeClassHandler);
+                app.service.addEventListener("ioError", classIOErrorHandler);
+                app.service.addEventListener("complete", classCompleteHandler);
                 app.service.url = computeFileName(_currentPackage + "." + _currentClass);
                 app.service.send();
                 _currentClassData = null;
@@ -355,16 +387,30 @@ package models
         private var _baseClassList:Array;
         
         private var _attributesMap:Object;
+
+        private function classIOErrorHandler(event:Event):void
+        {
+            app.service.removeEventListener("ioError", classIOErrorHandler);
+            app.service.removeEventListener("complete", classCompleteHandler);
+
+            // TODO: perhaps the list of classes should also include the list of
+            // platforms for each class so that we don't try to load files that
+            // don't exist!
+            // if we do that, we should log this error.
+
+            loadClassForNextPlatform();
+        }
         
         /**
-         * @royaleignorecoercion ASDocClass 
+         * @royaleignorecoercion ASDocClass
          * @royaleignorecoercion ASDocClassMembers
          * @royaleignorecoercion ASDocClassFunction
          * @royaleignorecoercion ASDocClassField
          */
-        private function completeClassHandler(event:Event):void
+        private function classCompleteHandler(event:Event):void
         {
-            app.service.removeEventListener("complete", completeClassHandler);
+            app.service.removeEventListener("ioError", classIOErrorHandler);
+            app.service.removeEventListener("complete", classCompleteHandler);
             var data:ASDocClass = app.reviver.parse(app.service.data) as ASDocClass;
             if (_currentClassData == null)
             {
@@ -419,7 +465,7 @@ package models
                     var a:ASDocClassAccessor = m as ASDocClassAccessor; // force link class
                     addIfNeededAndMakeAttributes(_publicProperties, a);
                 }
-else if (m.type == "field")
+                else if (m.type == "field")
                 {
                     var f:ASDocClassField = m as ASDocClassField; // force link class
                     addIfNeededAndMakeAttributes(_publicProperties, f);
@@ -467,35 +513,42 @@ else if (m.type == "field")
             if (data.type == "class" && data.baseClassname && 
             	data.baseClassname.indexOf("flash.") != 0  && data.baseClassname.indexOf("goog.") != 0)
             {
-                app.service.addEventListener("complete", completeClassHandler);
+                app.service.addEventListener("ioError", classIOErrorHandler);
+                app.service.addEventListener("complete", classCompleteHandler);
                 app.service.url = computeFileName(data.baseClassname);
                 app.service.send();
             }
             else if (data.type == "interface" && data.baseInterfaceNames && 
             	data.baseInterfaceNames[0].indexOf("flash.") != 0 && data.baseInterfaceNames[0].indexOf("goog.") != 0)
             {
+                app.service.addEventListener("ioError", classIOErrorHandler);
                 app.service.addEventListener("complete", completeInterfaceHandler);
                 extensions = data.baseInterfaceNames;
                 app.service.url = computeFileName(data.baseInterfaceNames[0]);
                 app.service.send();
-                
             }
             else
             {
-                if (platformList.length)
-                {
-                    currentPlatform = platformList.shift();
-                    app.service.addEventListener("complete", completeClassHandler);
-                    app.service.url = computeFileName(_currentPackage + "." + _currentClass);
-                    app.service.send();                    
-                }
-                else
-                {
-                    _publicMethods.sortOn("qname");
-                    _publicEvents.sortOn("qname");
-                    _publicProperties.sortOn("qname");
-                    dispatchEvent(new Event("currentDataChanged"));
-                }
+                loadClassForNextPlatform();
+            }
+        }
+
+        private function loadClassForNextPlatform():void
+        {
+            if (platformList.length)
+            {
+                currentPlatform = platformList.shift();
+                app.service.addEventListener("ioError", classIOErrorHandler);
+                app.service.addEventListener("complete", classCompleteHandler);
+                app.service.url = computeFileName(_currentPackage + "." + _currentClass);
+                app.service.send();                    
+            }
+            else
+            {
+                _publicMethods.sortOn("qname");
+                _publicEvents.sortOn("qname");
+                _publicProperties.sortOn("qname");
+                dispatchEvent(new Event("currentDataChanged"));
             }
         }
         
@@ -628,6 +681,24 @@ else if (m.type == "field")
         }
         
         private var extensions:Array;
+
+        private function loadInterfaceForNextPlatform():void
+        {
+            if (platformList.length)
+            {
+                currentPlatform = platformList.shift();
+                app.service.addEventListener("complete", completeInterfaceHandler);
+                app.service.url = computeFileName(_currentPackage + "." + _currentClass);
+                app.service.send();                                        
+            }
+            else
+            {
+                _publicMethods.sortOn("qname");
+                _publicEvents.sortOn("qname");
+                _publicProperties.sortOn("qname");
+                dispatchEvent(new Event("currentDataChanged"));
+            }
+        }
         
         /**
          * @royaleignorecoercion ASDocInterface 
@@ -729,20 +800,7 @@ else if (m.type == "field")
             }
             else
             {
-                if (platformList.length)
-                {
-                    currentPlatform = platformList.shift();
-                    app.service.addEventListener("complete", completeInterfaceHandler);
-                    app.service.url = computeFileName(_currentPackage + "." + _currentClass);
-                    app.service.send();                                        
-                }
-                else
-                {
-                    _publicMethods.sortOn("qname");
-                    _publicEvents.sortOn("qname");
-                    _publicProperties.sortOn("qname");
-                    dispatchEvent(new Event("currentDataChanged"));
-                }
+                loadInterfaceForNextPlatform();
             }
         }
         


(royale-asjs) 06/08: ASDoc: sanitize HTML for class description

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 8ff67d79effbd060a15c4596b4461deb0f522b32
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 17 15:55:19 2025 -0700

    ASDoc: sanitize HTML for class description
---
 examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml b/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
index 5c35bf1bde..ffcd1b647a 100644
--- a/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
+++ b/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
@@ -32,6 +32,7 @@ limitations under the License.
             import org.apache.royale.events.DetailEvent;
             import org.apache.royale.html.PopUpList;
             import org.apache.royale.utils.PointUtils;
+            import org.apache.royale.utils.string.sanitizeHtml;
 			
             private var packagesReady:Boolean = false;
             
@@ -504,7 +505,7 @@ limitations under the License.
                         <models:ListPresentationModel rowHeight="NaN"/>
                     </js:beads>
                 </js:DataContainer>
-	            <js:MultilineLabel id="description" className="description" html="{ASDocModel(applicationModel).description}" width="100%"/>
+	            <js:MultilineLabel id="description" className="description" html="{sanitizeHtml(ASDocModel(applicationModel).description)}" width="100%"/>
 	            <js:Label text="Public Properties" className="sectionLabel"/>
 	            <js:List className="summaryList" id="publicPropertyList" dataProvider="{ASDocModel(applicationModel).publicProperties}"
 	                     itemRenderer="SummaryRenderer" width="100%">


(royale-asjs) 04/08: ASDoc: add ASDocInterface for JSONReviver

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit c071c6fdcfb5a75ebf483c12c82352b686c7baa0
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 17 15:33:24 2025 -0700

    ASDoc: add ASDocInterface for JSONReviver
---
 .../royale/ASDoc/src/main/royale/ASDocInterface.as | 26 ++++++++++++++++++++++
 .../ASDoc/src/main/royale/models/ASDocModel.as     |  5 ++++-
 2 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/examples/royale/ASDoc/src/main/royale/ASDocInterface.as b/examples/royale/ASDoc/src/main/royale/ASDocInterface.as
new file mode 100644
index 0000000000..1a68918f3d
--- /dev/null
+++ b/examples/royale/ASDoc/src/main/royale/ASDocInterface.as
@@ -0,0 +1,26 @@
+////////////////////////////////////////////////////////////////////////////////
+//
+//  Licensed to the Apache Software Foundation (ASF) under one or more
+//  contributor license agreements.  See the NOTICE file distributed with
+//  this work for additional information regarding copyright ownership.
+//  The ASF licenses this file to You under the Apache License, Version 2.0
+//  (the "License"); you may not use this file except in compliance with
+//  the License.  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+package
+{
+[RemoteClass(alias='ASDocInterface')]
+public class ASDocInterface extends ASDocClass
+{
+    public static const key:String = "baseInterfaceNames:object;description:string;members:object;qname:string;tags:object;type:string";
+}
+}
diff --git a/examples/royale/ASDoc/src/main/royale/models/ASDocModel.as b/examples/royale/ASDoc/src/main/royale/models/ASDocModel.as
index f0bd9eae89..9a75d9e9b5 100644
--- a/examples/royale/ASDoc/src/main/royale/models/ASDocModel.as
+++ b/examples/royale/ASDoc/src/main/royale/models/ASDocModel.as
@@ -629,10 +629,13 @@ else if (m.type == "field")
         
         private var extensions:Array;
         
+        /**
+         * @royaleignorecoercion ASDocInterface 
+         */
         private function completeInterfaceHandler(event:Event):void
         {
             app.service.removeEventListener("complete", completeInterfaceHandler);
-            var data:ASDocClass = app.reviver.parse(app.service.data) as ASDocClass;
+            var data:ASDocInterface = app.reviver.parse(app.service.data) as ASDocInterface;
             if (_currentClassData == null)
             {
                 _currentClassData = data;


(royale-asjs) 03/08: ASDoc: fix issue where content was too big for body due to bad measurements from margin and flex-wrap

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 5f2a1a2dbf66dd70e2b703e385e4d00ec1361950
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 17 14:01:36 2025 -0700

    ASDoc: fix issue where content was too big for body due to bad measurements from margin and flex-wrap
---
 examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml b/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
index ae6567f3e8..5c35bf1bde 100644
--- a/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
+++ b/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
@@ -226,8 +226,9 @@ limitations under the License.
         }
         
         .titleGroup {
-        	margin-top: 30px;
-        	margin-left: 5px;
+        	padding-top: 36px;
+        	padding-left: 5px;
+            padding-right: 5px;
         }
         
         .detailsPane {
@@ -422,16 +423,15 @@ limitations under the License.
         <js:CallLaterBead id="clb" />
     </rs:beads>
     <rs:DocTopBar />
-    <rs:DocTagline />
     <js:Group width="100%" id="titleGroup" className="titleGroup">
         <js:beads>
-            <js:OneFlexibleChildHorizontalLayoutForOverflow flexibleChild="spacer" />
+            <js:FlexibleFirstChildHorizontalLayout />
         </js:beads>
         <js:Label text="Apache Royale ActionScript Library Reference" id="title" height="30" className="title"/>
         <js:Spacer width="20" />
         <js:Label text="Find a class" className="findClassLabel"/>
         <js:TextInput id="searchTI" className="searchTI" change="search()" />
-        <js:Spacer id="spacer" />
+        <js:Spacer id="spacer" width="20" />
         <js:CheckBox id="topLevel" text="Top-Level" click="showTopLevel()" />
         <js:CheckBox id="viewBeads" text="View Bead" click="showViewBeads()" />
     </js:Group>


(royale-asjs) 02/08: RoyaleSite: make the top bar layout match the real site a bit better

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 69b101805a62a0b222dba15b406c6094a662ad20
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 17 13:32:54 2025 -0700

    RoyaleSite: make the top bar layout match the real site a bit better
---
 .../RoyaleSite/src/main/resources/defaults.css     | 29 +++++++++++++++-------
 .../royale/org/apache/royale/site/DocTopBar.mxml   |  1 -
 2 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/frameworks/projects/RoyaleSite/src/main/resources/defaults.css b/frameworks/projects/RoyaleSite/src/main/resources/defaults.css
index eb745a190e..0c0bb70c90 100644
--- a/frameworks/projects/RoyaleSite/src/main/resources/defaults.css
+++ b/frameworks/projects/RoyaleSite/src/main/resources/defaults.css
@@ -162,9 +162,9 @@ rs|MainPage {
 rs|DocPage {
 	width: 100%;
 	background-image: url('https://royale.apache.org/wp-content/uploads/2017/10/page-bg-1-1920x300.png');
-	background-size: 100%;
 	background-repeat: no-repeat;
 	margin-top: 0px;
+	background-position: center top;
 }
 
 rs|SocialButtons {
@@ -195,29 +195,32 @@ rs|TopBar {
 
 rs|DocTopBar {
 	display: flex;
-	flex-wrap: wrap;
 	justify-content: space-between;
 	padding-left: 54px;
-	padding-right: 54px;
+	padding-right: 20px;
 	color: #fff;
 }
 
 rs|TopMenu {
-	display: inline-block;
-	vertical-align: top;
-	margin-top: 0px;
+	display: inline-flex;
+	flex: 1 1 auto;
+	flex-wrap: wrap;
+	justify-content: flex-end;
+	margin-top: 15px;
 	margin-bottom: 0px;
 	height: 40px;
 	list-style: none;
+	flex-grow: 1;
+	text-align: right;
 }
 
 rs|TopMenuButton {
 	display: inline;
-	margin-right: 20px;
+	margin-left: 20px;
 	font-size: 14px;
 	font-weight: 600;
 	font-family: 'Signika';
-	line-height: 70px;
+	line-height: 40px;
 	letter-spacing: 1px;
 	color: inherit;
 }
@@ -377,6 +380,14 @@ rs|TitledAnchorList {
 .logo {
     margin-top:15px; 
     margin-bottom: 5px; 
-    width: 190px; 
+    width: 180px; 
     height: 40px;
+}
+
+
+@media (max-width: 590px) {
+	/* the menu items wrap, and this is when the layout starts to break */
+	.TopMenu {
+		display: none;
+	}
 }
\ No newline at end of file
diff --git a/frameworks/projects/RoyaleSite/src/main/royale/org/apache/royale/site/DocTopBar.mxml b/frameworks/projects/RoyaleSite/src/main/royale/org/apache/royale/site/DocTopBar.mxml
index bb42c53249..f1f2159cbd 100644
--- a/frameworks/projects/RoyaleSite/src/main/royale/org/apache/royale/site/DocTopBar.mxml
+++ b/frameworks/projects/RoyaleSite/src/main/royale/org/apache/royale/site/DocTopBar.mxml
@@ -25,5 +25,4 @@ limitations under the License.
                  className="DocTopBar TopBar">
     <Img className="logo" src="https://royale.apache.org/wp-content/uploads/2018/01/apache-royale-tm-logo-light.svg" />
     <rs:TopMenu />
-    <rs:SocialButtons />
 </Div>
\ No newline at end of file


(royale-asjs) 08/08: ASDoc: stricter builds

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit a76f7fb8f7dbd2ef860e2d89efd94d4d6ca5bd4b
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Apr 17 15:56:05 2025 -0700

    ASDoc: stricter builds
---
 examples/royale/ASDoc/build.xml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/examples/royale/ASDoc/build.xml b/examples/royale/ASDoc/build.xml
index 032a0296b6..ab6795eebe 100644
--- a/examples/royale/ASDoc/build.xml
+++ b/examples/royale/ASDoc/build.xml
@@ -111,7 +111,6 @@
                 <not>
                     <or>
                         <equals arg1="${errorCodeJS}" arg2="0" />
-                        <equals arg1="${errorCodeJS}" arg2="2" />
                     </or>
                 </not>
             </condition>
@@ -158,7 +157,6 @@
                 <not>
                     <or>
                         <equals arg1="${errorCodeSWF}" arg2="0" />
-                        <equals arg1="${errorCodeSWF}" arg2="2" />
                     </or>
                 </not>
             </condition>