You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/07/28 14:51:40 UTC
Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if
the subsequent logic relies on the outcome.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Jan Schlicht.
Repository: mesos
Description
-------
FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.
Diffs
-----
src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57
Diff: https://reviews.apache.org/r/36889/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT
if the subsequent logic relies on the outcome.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93288
-----------------------------------------------------------
src/tests/fetcher_cache_tests.cpp (line 368)
<https://reviews.apache.org/r/36889/#comment147669>
s/EXPECT_NE/ASSERT_NE
src/tests/fetcher_cache_tests.cpp (line 568)
<https://reviews.apache.org/r/36889/#comment147661>
s/EXPECT_SOME/ASSERT_SOME, as Try::isSome() is expected true in the next line. There are probably more cases like this.
src/tests/fetcher_cache_tests.cpp (line 606)
<https://reviews.apache.org/r/36889/#comment147662>
s/EXPECT_SOME/ASSERT_SOME
src/tests/fetcher_cache_tests.cpp (line 656)
<https://reviews.apache.org/r/36889/#comment147664>
s/EXPECT_SOME/ASSERT_SOME
src/tests/fetcher_cache_tests.cpp (line 693)
<https://reviews.apache.org/r/36889/#comment147665>
s/EXPECT_SOME/ASSERT_SOME
src/tests/fetcher_cache_tests.cpp (line 729)
<https://reviews.apache.org/r/36889/#comment147666>
s/EXPECT_SOME/ASSERT_SOME
src/tests/fetcher_cache_tests.cpp (line 867)
<https://reviews.apache.org/r/36889/#comment147667>
s/EXPECT_SOME/ASSERT_SOME
src/tests/fetcher_cache_tests.cpp (line 930)
<https://reviews.apache.org/r/36889/#comment147668>
s/EXPECT_SOME/ASSERT_SOME
- Jan Schlicht
On July 28, 2015, 2:52 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36889/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 2:52 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Jan Schlicht.
>
>
> Bugs: MESOS-3112
> https://issues.apache.org/jira/browse/MESOS-3112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57
>
> Diff: https://reviews.apache.org/r/36889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT
if the subsequent logic relies on the outcome.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93311
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36889]
All tests passed.
- Mesos ReviewBot
On July 28, 2015, 1:48 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36889/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 1:48 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Jan Schlicht.
>
>
> Bugs: MESOS-3112
> https://issues.apache.org/jira/browse/MESOS-3112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57
>
> Diff: https://reviews.apache.org/r/36889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT
if the subsequent logic relies on the outcome.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93444
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On July 29, 2015, 6:11 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36889/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 6:11 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Jan Schlicht.
>
>
> Bugs: MESOS-3171
> https://issues.apache.org/jira/browse/MESOS-3171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57
>
> Diff: https://reviews.apache.org/r/36889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT
if the subsequent logic relies on the outcome.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/
-----------------------------------------------------------
(Updated July 29, 2015, 1:11 p.m.)
Review request for mesos, Bernd Mathiske and Jan Schlicht.
Bugs: MESOS-3171
https://issues.apache.org/jira/browse/MESOS-3171
Repository: mesos
Description
-------
FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.
Diffs
-----
src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57
Diff: https://reviews.apache.org/r/36889/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT
if the subsequent logic relies on the outcome.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93297
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On July 28, 2015, 3:48 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36889/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 3:48 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Jan Schlicht.
>
>
> Bugs: MESOS-3112
> https://issues.apache.org/jira/browse/MESOS-3112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57
>
> Diff: https://reviews.apache.org/r/36889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT
if the subsequent logic relies on the outcome.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/
-----------------------------------------------------------
(Updated July 28, 2015, 1:48 p.m.)
Review request for mesos, Bernd Mathiske and Jan Schlicht.
Bugs: MESOS-3112
https://issues.apache.org/jira/browse/MESOS-3112
Repository: mesos
Description
-------
FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57
Diff: https://reviews.apache.org/r/36889/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT
if the subsequent logic relies on the outcome.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93295
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36889]
All tests passed.
- Mesos ReviewBot
On July 28, 2015, 12:52 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36889/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 12:52 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Jan Schlicht.
>
>
> Bugs: MESOS-3112
> https://issues.apache.org/jira/browse/MESOS-3112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57
>
> Diff: https://reviews.apache.org/r/36889/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT
if the subsequent logic relies on the outcome.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/
-----------------------------------------------------------
(Updated July 28, 2015, 12:52 p.m.)
Review request for mesos, Bernd Mathiske and Jan Schlicht.
Bugs: MESOS-3112
https://issues.apache.org/jira/browse/MESOS-3112
Repository: mesos
Description
-------
FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.
Diffs
-----
src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57
Diff: https://reviews.apache.org/r/36889/diff/
Testing
-------
make check
Thanks,
Joerg Schad