[GitHub] [arrow] rok commented on a change in pull request #12528: ARROW-15251: [C++] Temporal floor/ceil/round handle ambiguous/nonexistent local time

[GitBox <gi...@apache.org>]

rok commented on a change in pull request #12528:
URL: https://github.com/apache/arrow/pull/12528#discussion_r816830917



##########
File path: cpp/src/arrow/compute/api_scalar.cc
##########
@@ -100,39 +100,37 @@ struct EnumTraits<compute::CompareOperator>
   }
 };
 template <>
-struct EnumTraits<compute::AssumeTimezoneOptions::Ambiguous>
-    : BasicEnumTraits<compute::AssumeTimezoneOptions::Ambiguous,
-                      compute::AssumeTimezoneOptions::Ambiguous::AMBIGUOUS_RAISE,
-                      compute::AssumeTimezoneOptions::Ambiguous::AMBIGUOUS_EARLIEST,
-                      compute::AssumeTimezoneOptions::Ambiguous::AMBIGUOUS_LATEST> {
+struct EnumTraits<compute::Ambiguous>
+    : BasicEnumTraits<compute::Ambiguous, compute::Ambiguous::AMBIGUOUS_RAISE,
+                      compute::Ambiguous::AMBIGUOUS_EARLIEST,
+                      compute::Ambiguous::AMBIGUOUS_LATEST> {

Review comment:
       I'm not sure if `AssumeTimezoneOptions::Ambiguous` and `RoundTemporalOptions::Ambiguous` would have the same options long-term (same for nonexistent). For now this change seems like the way to go, I'm just wondering if the name `compute::Ambiguous` should maybe be `compute::AmbiguousTime` (and `compute::NonexistentTime`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org