You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Thomas Jungblut (Created) (JIRA)" <ji...@apache.org> on 2011/10/07 12:22:30 UTC
[jira] [Created] (HAMA-448) Restructure BSP API
Restructure BSP API
-------------------
Key: HAMA-448
URL: https://issues.apache.org/jira/browse/HAMA-448
Project: Hama
Issue Type: Improvement
Reporter: Thomas Jungblut
Fix For: 0.4.0
Excerpt from the mailing list:
I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
To retrieve the job's configuration, the user should use peer.getConfiguration().
Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-448) Restructure BSP API
Posted by "ChiaHung Lin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124012#comment-13124012 ]
ChiaHung Lin commented on HAMA-448:
-----------------------------------
Though this is trivial, maybe we can test reviews.apache.org with this patch?
Have a look at patch, the code looks good.
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
> Attachments: HAMA-448_v1.patch
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-448) Restructure BSP API
Posted by "Thomas Jungblut (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Jungblut updated HAMA-448:
---------------------------------
Status: Patch Available (was: Open)
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
> Attachments: HAMA-448_v1.patch
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-448) Restructure BSP API
Posted by "Thomas Jungblut (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124207#comment-13124207 ]
Thomas Jungblut commented on HAMA-448:
--------------------------------------
Review opened here:
https://reviews.apache.org/r/2331/
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
> Attachments: HAMA-448_v1.patch
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-448) Restructure BSP API
Posted by "Thomas Jungblut (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125649#comment-13125649 ]
Thomas Jungblut commented on HAMA-448:
--------------------------------------
Okay fine, but we have forgotten that setup() should throw checked exceptions.
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
> Attachments: HAMA-448_v1.patch
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-448) Restructure BSP API
Posted by "Thomas Jungblut (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124182#comment-13124182 ]
Thomas Jungblut commented on HAMA-448:
--------------------------------------
I can't open a review request, is there a tutorial how to use it?
I get can upload the diff and give the project url as absolute path from apache svn root.
He says he can't find the resources.
Additional note to my patch: We have to add "throws blabla Exception" in setup method to enable the message sending/syncing without letting the user catch them.
Same story in cleanup.
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
> Attachments: HAMA-448_v1.patch
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-448) Restructure BSP API
Posted by "Thomas Jungblut (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Jungblut updated HAMA-448:
---------------------------------
Attachment: HAMA-448_v1.patch
Restructured the API.
Please review.
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
> Attachments: HAMA-448_v1.patch
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-448) Restructure BSP API
Posted by "Thomas Jungblut (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122678#comment-13122678 ]
Thomas Jungblut commented on HAMA-448:
--------------------------------------
Scheduled this to 0.4.0 because it is not too much work.
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HAMA-448) Restructure BSP API
Posted by "Thomas Jungblut (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Jungblut reassigned HAMA-448:
------------------------------------
Assignee: Thomas Jungblut
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-448) Restructure BSP API
Posted by "Thomas Jungblut (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124017#comment-13124017 ]
Thomas Jungblut commented on HAMA-448:
--------------------------------------
Sure, let's try this out.
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
> Attachments: HAMA-448_v1.patch
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-448) Restructure BSP API
Posted by "Edward J. Yoon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125537#comment-13125537 ]
Edward J. Yoon commented on HAMA-448:
-------------------------------------
Looks good to me +1
I just commit this patch to the trunk!
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
> Attachments: HAMA-448_v1.patch
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-448) Restructure BSP API
Posted by "Thomas Jungblut (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Jungblut updated HAMA-448:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
resolved because it is committed and I've added the checked exceptions in the setup method.
> Restructure BSP API
> -------------------
>
> Key: HAMA-448
> URL: https://issues.apache.org/jira/browse/HAMA-448
> Project: Hama
> Issue Type: Improvement
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Labels: bsp
> Fix For: 0.4.0
>
> Attachments: HAMA-448_v1.patch
>
>
> Excerpt from the mailing list:
> I would like to add a setup(BSPPeer peer) and a cleanup(BSPPeer peer) method to our abstract BSP class.
> In addition I want to implement the setConfiguration and getConfiguration in our abstract BSP class, add a Configuration field, and set them to deprecated. (maybe we can remove them in our 5.0 release).
> To retrieve the job's configuration, the user should use peer.getConfiguration().
> Similar to the Hadoop flow, we are executing setup->bsp->cleanup.
> Maybe we can refactor our examples to match this new possibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira