You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2013/04/09 21:58:15 UTC

Review Request: SQOOP-723 Add possibility to have synchronous submissions in Sqoop 2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10383/
-----------------------------------------------------------

Review request for Sqoop, Jarek Cecho and Kathleen Ting.


Description
-------

commit 0ce5525d2cb74a154b3c70694c8463640f87fdbb
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date:   Mon Apr 8 09:06:27 2013 -0700

    SQOOP-723 Add possibility to have synchronous submissions in Sqoop 2

:100644 100644 cc956d0... de6b362... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 cefe0a2... e9a33bf... M	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 100644 feb09e0... bfc005d... M	client/src/main/resources/client-resource.properties


This addresses bug SQOOP-723.
    https://issues.apache.org/jira/browse/SQOOP-723


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java cc956d0f9306a08ef9084e7b878f82e3e355d617 
  client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java cefe0a2cfd1e7add6802e1f18d40c5e8e717ec96 
  client/src/main/resources/client-resource.properties feb09e0d40dc66e5475b9183d6d98a19eb98f357 

Diff: https://reviews.apache.org/r/10383/diff/


Testing
-------

Ran all unit tests and integration tests.
Manually tested synchronous execution.


Thanks,

Abraham Elmahrek


Re: Review Request: SQOOP-723 Add possibility to have synchronous submissions in Sqoop 2

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10383/#review19128
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On April 9, 2013, 7:58 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10383/
> -----------------------------------------------------------
> 
> (Updated April 9, 2013, 7:58 p.m.)
> 
> 
> Review request for Sqoop, Jarek Cecho and Kathleen Ting.
> 
> 
> Description
> -------
> 
> commit 0ce5525d2cb74a154b3c70694c8463640f87fdbb
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Mon Apr 8 09:06:27 2013 -0700
> 
>     SQOOP-723 Add possibility to have synchronous submissions in Sqoop 2
> 
> :100644 100644 cc956d0... de6b362... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 cefe0a2... e9a33bf... M	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 feb09e0... bfc005d... M	client/src/main/resources/client-resource.properties
> 
> 
> This addresses bug SQOOP-723.
>     https://issues.apache.org/jira/browse/SQOOP-723
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java cc956d0f9306a08ef9084e7b878f82e3e355d617 
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java cefe0a2cfd1e7add6802e1f18d40c5e8e717ec96 
>   client/src/main/resources/client-resource.properties feb09e0d40dc66e5475b9183d6d98a19eb98f357 
> 
> Diff: https://reviews.apache.org/r/10383/diff/
> 
> 
> Testing
> -------
> 
> Ran all unit tests and integration tests.
> Manually tested synchronous execution.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>