You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/12/20 10:32:46 UTC

[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3709: [improve] Add journal retention time policy

wenbingshen opened a new pull request, #3709:
URL: https://github.com/apache/bookkeeper/pull/3709

   ### Motivation
   
   Fixes #3708 
   
   ### Changes
   Add two configs:
   
   `journalRetentionTimeEnable`
   `maxJournalRetentionTimeMs`
   
   `journalRetentionTimeEnable` is disabled by default, consistent with existing logic.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] hangc0276 commented on pull request #3709: [improve] Add journal retention time policy

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3709:
URL: https://github.com/apache/bookkeeper/pull/3709#issuecomment-1359594238

   You can set `maxBackupJournals` to `0` to achieve your goal


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] hangc0276 commented on pull request #3709: [improve] Add journal retention time policy

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3709:
URL: https://github.com/apache/bookkeeper/pull/3709#issuecomment-1369309859

   > > You can set `maxBackupJournals` to `0` to achieve your goal
   > 
   > No. my goal is not maxBackupJournals=0, you can check the detailed description in the issue #3708
   
   @wenbingshen 
   > We hope that when the traffic peaks, a few more journal file backups can help us restore the bookie in abnormal situations, but we also hope that when the traffic is low, we can clean up the journal files that have been backed up for a long time.
   
   This is your requirement, right?  If you set maxBackupJournals to `0`, the journal files will be deleted immediately after the journal checkpoint is completed. No matter if there is high traffic or not, the policy can ensure no data loss.
   
   The journal files can be cleaned up based on the maxBackup policy, and won't cost too much disk space. I'm not sure whether it is valuable to introduce the time based retention policy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] hangc0276 commented on pull request #3709: [improve] Add journal retention time policy

Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #3709:
URL: https://github.com/apache/bookkeeper/pull/3709#issuecomment-1534078685

   @wenbingshen Do you have any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] wenbingshen commented on pull request #3709: [improve] Add journal retention time policy

Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3709:
URL: https://github.com/apache/bookkeeper/pull/3709#issuecomment-1360833325

   > You can set `maxBackupJournals` to `0` to achieve your goal
   
   No. my goal is not maxBackupJournals=0, you can check the detailed description in the issue #3708 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org