You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Igor Rudyak <ir...@gmail.com> on 2018/05/10 19:58:38 UTC

One more round for PR review

Hi guys,

I addressed all the comments and need one more round of review for the PR:
https://github.com/apache/ignite/pull/3940

Igor

Re: One more round for PR review

Posted by Dmitry Pavlov <dp...@gmail.com>.

Hi Alexey, thank you for review.

Hi Igor, could you please merge this PR?

вт, 15 мая 2018 г. в 11:18, Alexey Kuznetsov <ak...@apache.org>:

> Looks good for me now.
>
> On Tue, May 15, 2018 at 12:38 AM, Dmitry Pavlov <dp...@gmail.com>
> wrote:
>
> > Hi Alexey K,
> >
> > could you please check that all proposals were applied?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > чт, 10 мая 2018 г. в 22:59, Igor Rudyak <ir...@gmail.com>:
> >
> > > Hi guys,
> > >
> > > I addressed all the comments and need one more round of review for the
> > PR:
> > > https://github.com/apache/ignite/pull/3940
> > >
> > > Igor
> > >
> >
>
>
>
> --
> Alexey Kuznetsov
>

Re: One more round for PR review

Posted by Alexey Kuznetsov <ak...@apache.org>.

Looks good for me now.

On Tue, May 15, 2018 at 12:38 AM, Dmitry Pavlov <dp...@gmail.com>
wrote:

> Hi Alexey K,
>
> could you please check that all proposals were applied?
>
> Sincerely,
> Dmitriy Pavlov
>
> чт, 10 мая 2018 г. в 22:59, Igor Rudyak <ir...@gmail.com>:
>
> > Hi guys,
> >
> > I addressed all the comments and need one more round of review for the
> PR:
> > https://github.com/apache/ignite/pull/3940
> >
> > Igor
> >
>



-- 
Alexey Kuznetsov

Re: One more round for PR review

Posted by Dmitry Pavlov <dp...@gmail.com>.

Hi Alexey K,

could you please check that all proposals were applied?

Sincerely,
Dmitriy Pavlov

чт, 10 мая 2018 г. в 22:59, Igor Rudyak <ir...@gmail.com>:

> Hi guys,
>
> I addressed all the comments and need one more round of review for the PR:
> https://github.com/apache/ignite/pull/3940
>
> Igor
>