You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/09/14 07:51:34 UTC

[GitHub] [incubator-opendal] Xuanwo opened a new pull request, #3061: chore: Polish some details of layers implementation

Xuanwo opened a new pull request, #3061:
URL: https://github.com/apache/incubator-opendal/pull/3061

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #3061: chore: Polish some details of layers implementation

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3061:
URL: https://github.com/apache/incubator-opendal/pull/3061#discussion_r1325594886


##########
bindings/java/src/blocking_operator.rs:
##########
@@ -24,14 +24,14 @@ use jni::objects::JString;
 use jni::sys::jlong;
 use jni::sys::jstring;
 use jni::JNIEnv;
-
 use opendal::layers::BlockingLayer;
 use opendal::BlockingOperator;
 use opendal::Operator;
 use opendal::Scheme;
 
+use crate::get_global_runtime;

Review Comment:
   We are using `imports_granularity = "Item"` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #3061: chore: Polish some details of layers implementation

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3061:
URL: https://github.com/apache/incubator-opendal/pull/3061#discussion_r1325591525


##########
bindings/java/src/blocking_operator.rs:
##########
@@ -24,14 +24,14 @@ use jni::objects::JString;
 use jni::sys::jlong;
 use jni::sys::jstring;
 use jni::JNIEnv;
-
 use opendal::layers::BlockingLayer;
 use opendal::BlockingOperator;
 use opendal::Operator;
 use opendal::Scheme;
 
+use crate::get_global_runtime;

Review Comment:
   Why is this style not converged?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo merged pull request #3061: chore: Polish some details of layers implementation

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3061:
URL: https://github.com/apache/incubator-opendal/pull/3061


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org