You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by markwpearce <gi...@git.apache.org> on 2014/09/15 21:47:32 UTC
[GitHub] cordova-plugin-geolocation pull request: iOS: Clearing all Watches...
GitHub user markwpearce opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/25
iOS: Clearing all Watches stops Location Services
iOS shows a little arrow in the status bar if location services are in use. When you set a watch on Location Manager, it starts tracking position, and the arrow symbol appears. However, when that watch is cleared, no command to Location Manager is sent to stop tracking, so the arrow stays visible, even though in reality, the app is not using location services. My guess is that this also impacts battery life to some extent, especially if your iOS app has background location enabled.
This fix would automatically stop tracking location once all watched are cleared, so that the arrow symbol in the iOS status will disappear.
Tested on iOS 7.1.2.
(Note: I don't really want to go through the rigamarole of signing up to be a contributor, so if someone else wants to take credit for this, go ahead)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markwpearce/cordova-plugin-geolocation patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 974c9199891b6d2c07b6abc18591a6b733cc05fa
Author: Mark Pearce <ma...@gmail.com>
Date: 2014-09-15T19:43:08Z
iOS: Clearing all Watches stops Location Services
iOS shows a little arrow in the status bar if location services are in use. When you set a watch on Location Manager, it starts tracking position, and the arrow symbol appears. However, when that watch is cleared, no command to Location Manager is sent to stop tracking, so the arrow stays visible, even though in reality, the app is not using location services. My guess is that this also impacts battery life to some extent, especially if your iOS app has background location enabled.
This fix would automatically stop tracking location once all watched are cleared, so that the arrow symbol in the iOS status will disappear.
Tested on iOS 7.1.2.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-geolocation pull request: iOS: Clearing all Watches...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/25#issuecomment-55666711
This is a trivial fix, so an iCLA would not be needed. Thanks for the contrib.
Filed: https://issues.apache.org/jira/browse/CB-7556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-geolocation pull request: iOS: Clearing all Watches...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/25#issuecomment-58731667
Please file an issue for Android at:
http://issues.apache.org/jira/browse/CB
... so it can be tracked and evaluated by the devs, and you can be notified.
Sign up here:
https://issues.apache.org/jira/secure/Signup!default.jspa
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: iOS: Clearing all Watches...
Posted by paishin <gi...@git.apache.org>.
Github user paishin commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/25#issuecomment-102430924
I can confirm that serious battery drainage occurs when using this plugin because location services and gps tracking remain active
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: iOS: Clearing all Watches...
Posted by Pushkar13008 <gi...@git.apache.org>.
Github user Pushkar13008 commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/25#issuecomment-58625893
Hi,
I use cordova 3.6 and last version of geolocation. I have the same issue on Android. When the watch is cleared, the symbol stays visible.
Is it possible to fix this ?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: iOS: Clearing all Watches...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/25#issuecomment-169134225
This PR can be closed - the commit has been merged https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=551b404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: iOS: Clearing all Watches...
Posted by Tempus35 <gi...@git.apache.org>.
Github user Tempus35 commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/25#issuecomment-173720901
I am having this issue still on android
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org