You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/09 16:22:31 UTC
[GitHub] [airflow] gaborratky-db opened a new pull request, #25623: DatabricksSubmitRunOperator dbt task support
gaborratky-db opened a new pull request, #25623:
URL: https://github.com/apache/airflow/pull/25623
This PR adds support for the upcoming `dbt_task` to `DatabricksSubmitRunOperator`.
Databricks is launching the Public Preview of the dbt task [1] soon, and this small change adds first-class support to `DatabricksSubmitRunOperator`. The official documentation for the dbt task will go live as part of the Public Preview.
Please let me know if the PR should include any other changes related to supporting the new task type.
### Checklist
* [ ] Add news fragment to PR
* [ ] Tests and PR checks pass
[1] https://www.databricks.com/blog/2022/06/29/top-5-workflows-announcements-at-data-ai-summit.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on a diff in pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
alexott commented on code in PR #25623:
URL: https://github.com/apache/airflow/pull/25623#discussion_r941598917
##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -333,6 +341,8 @@ def __init__(
self.json['spark_submit_task'] = spark_submit_task
if pipeline_task is not None:
self.json['pipeline_task'] = pipeline_task
+ if dbt_task is not None:
+ self.json['dbt_task'] = dbt_task
Review Comment:
If the git source is required, I would move this code after this line https://github.com/apache/airflow/pull/25623/files#diff-30731826b25d422cb6069898701e34f8ef23b2a32b7782444793a14bc52b0cb1L352 and throw exception if it isn’t set - this will allow to catch misconfigurations early…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gaborratky-db commented on pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
gaborratky-db commented on PR #25623:
URL: https://github.com/apache/airflow/pull/25623#issuecomment-1214927831
@mik-laj rebased to latest `main`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
mik-laj commented on PR #25623:
URL: https://github.com/apache/airflow/pull/25623#issuecomment-1213288238
Can you do a rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gaborratky-db commented on pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
gaborratky-db commented on PR #25623:
URL: https://github.com/apache/airflow/pull/25623#issuecomment-1229880306
Thank you for the review and merging of the changes, @potiuk!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gaborratky-db commented on pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
gaborratky-db commented on PR #25623:
URL: https://github.com/apache/airflow/pull/25623#issuecomment-1213260330
Hi @mik-laj, the CI checks seem to have failed on unrelated issues (`docker: i/o timeout` & `breeze: command not found`), would it be possible to run these checks again to arrive at a successful state? Thank you and have a great weekend!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gaborratky-db commented on pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
gaborratky-db commented on PR #25623:
URL: https://github.com/apache/airflow/pull/25623#issuecomment-1211774388
Hello @mik-laj, how are you? Being a first-time contributor, can I ask you to approve running the workflows so that I can address any issues the PR checks raise? The change is a minor improvement to `DatabricksSubmitRunOperator`.
Also, cc-ing @potiuk, who has previously handled Databricks-related PRs. Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
mik-laj commented on PR #25623:
URL: https://github.com/apache/airflow/pull/25623#issuecomment-1211775304
Ci starting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gaborratky-db commented on pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
gaborratky-db commented on PR #25623:
URL: https://github.com/apache/airflow/pull/25623#issuecomment-1216257428
Thanks for the suggestion, @mik-laj; the PR has passed all checks. Is there anything else I can do ahead of your code review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25623:
URL: https://github.com/apache/airflow/pull/25623#issuecomment-1209599488
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25623:
URL: https://github.com/apache/airflow/pull/25623#issuecomment-1228924689
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25623: DatabricksSubmitRunOperator dbt task support
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25623:
URL: https://github.com/apache/airflow/pull/25623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org