[jira] [Commented] (CAMEL-10725) camel-zipkin - Upgrade to zipkin brave 4.x

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515585#comment-16515585 ] 

ASF GitHub Bot commented on CAMEL-10725:
----------------------------------------

GitHub user adriancole opened a pull request:

    https://github.com/apache/camel/pull/2383

    Spikes Brave 5 conversion

    This is CAMEL-10725
    
    I still think the instrumentation could use revisiting, but the point of this change isn't to do that, rather to port the code to the new apis.
    
    I would love for someone to pick this up and carry it over the finish line if possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adriancole/camel brave5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2383
    
----
commit 6b05839e9d224f93ac9877c75b9ad8e646215ac3
Author: Adrian Cole <ac...@...>
Date:   2018-06-18T10:57:53Z

    Spikes Brave 5 conversion

----


> camel-zipkin - Upgrade to zipkin brave 4.x
> ------------------------------------------
>
>                 Key: CAMEL-10725
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10725
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-zipkin
>            Reporter: Claus Ibsen
>            Assignee: Andrea Cosentino
>            Priority: Major
>             Fix For: 2.19.0
>
>
> We should use io.zipkin.brave 4.x instead of that older 3.x which was not official part of zipkin.
> OSGi users may need a new SMX bundle of the 4.x as well if its not osgi already.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)