You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by "Andreas L. Delmelle" <a_...@pandora.be> on 2004/01/19 20:03:59 UTC

Properties question ( again? )


Hi,

While strolling through the table classes, I wondered about the following:

fop.fo.flow.Table
line 157:    CommonBackground bProps = propMgr.getBackgroundProps();

line 193:    this.BackgroundColor =
this.propertyList.get(PR_BACKGROUND_COLOR).getColorType();

How should I see this? Is one of the two superfluous? Do they complement
each other? Shouldn't the latter be rewritten as :

    this.BackgroundColor = bProps.backColor


Anyone?

TIA

Cheers,

Andreas

Re: Properties question ( again? )

Posted by Finn Bock <bc...@worldonline.dk>.
[J.Pietschmann]

> I thought porpertyList had been retired in HEAD?

PropertyListBuilder was recently removed from HEAD.


[Andreas L. Delmelle]

> How should I see this? Is one of the two superfluous? Do they complement
> each other? Shouldn't the latter be rewritten as :
>
>     this.BackgroundColor = bProps.backColor

That is also my feeling.

regards,
finn

RE: Properties question ( again? )

Posted by Glen Mazza <gr...@yahoo.com>.
Please fix it whenever you get write access.

Glen

--- "Andreas L. Delmelle" <a_...@pandora.be>
wrote:
> > > Shouldn't the latter be rewritten as :
> > > 
> > >     this.BackgroundColor = bProps.backColor
> > 
> > I'd think so.
> > 
> 


__________________________________
Do you Yahoo!?
Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes
http://hotjobs.sweepstakes.yahoo.com/signingbonus

RE: Properties question ( again? )

Posted by "Andreas L. Delmelle" <a_...@pandora.be>.
> -----Original Message-----
> From: J.Pietschmann [mailto:j3322ptm@yahoo.de]
> 
> > 
> I thought porpertyList had been retired in HEAD?
> 

That's what I initially thought, but got a bit confused...

> > Shouldn't the latter be rewritten as :
> > 
> >     this.BackgroundColor = bProps.backColor
> 
> I'd think so.
> 

Ok. Probably means reviewing a few patches submitted recently.

Thanks for the quick response.


Cheers,

Andreas

Re: Properties question ( again? )

Posted by "J.Pietschmann" <j3...@yahoo.de>.
Andreas L. Delmelle wrote:
> fop.fo.flow.Table
> line 157:    CommonBackground bProps = propMgr.getBackgroundProps();
> 
> line 193:    this.BackgroundColor =
> this.propertyList.get(PR_BACKGROUND_COLOR).getColorType();
> 
I thought porpertyList had been retired in HEAD?

> How should I see this? Is one of the two superfluous? Do they complement
> each other? Shouldn't the latter be rewritten as :
> 
>     this.BackgroundColor = bProps.backColor

I'd think so.

J.Pietschmann