You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/30 06:17:29 UTC
[GitHub] [kafka] kowshik opened a new pull request #9536: MINOR: KIP-584: Remove admin client facility to read features from controller
kowshik opened a new pull request #9536:
URL: https://github.com/apache/kafka/pull/9536
In this PR, I have eliminated the facility in `Admin#describeFeatures` API and it's implementation to be able to optionally send a `describeFeatures` request to the controller. This feature was not seen to be particularly useful, and besides it also poses some hindrance to post KIP-500 world where no client would be able to access the controller directly.
**Test plan:**
Rely on existing unit & integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9536: MINOR: KIP-584: Remove admin client facility to read features from controller
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9536:
URL: https://github.com/apache/kafka/pull/9536#issuecomment-720276930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao merged pull request #9536: MINOR: KIP-584: Remove admin client facility to read features from controller
Posted by GitBox <gi...@apache.org>.
junrao merged pull request #9536:
URL: https://github.com/apache/kafka/pull/9536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on a change in pull request #9536: MINOR: KIP-584: Remove admin client facility to read features from controller
Posted by GitBox <gi...@apache.org>.
kowshik commented on a change in pull request #9536:
URL: https://github.com/apache/kafka/pull/9536#discussion_r515769357
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -4353,11 +4353,8 @@ void handleFailure(Throwable throwable) {
public DescribeFeaturesResult describeFeatures(final DescribeFeaturesOptions options) {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9536: MINOR: KIP-584: Remove admin client facility to read features from controller
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9536:
URL: https://github.com/apache/kafka/pull/9536#issuecomment-719268329
cc @abbccdda @cmccabe @junrao -- this PR is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9536: MINOR: KIP-584: Remove admin client facility to read features from controller
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9536:
URL: https://github.com/apache/kafka/pull/9536#discussion_r515749438
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -4353,11 +4353,8 @@ void handleFailure(Throwable throwable) {
public DescribeFeaturesResult describeFeatures(final DescribeFeaturesOptions options) {
Review comment:
how about adding ```@Override```?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org