You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/02/18 22:46:10 UTC
Review Request 18239: rename ThermosExecutor to AuroraExecutor,
clean up thermos-isms from ExecutorBase
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18239/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
Bugs: AURORA-186
https://issues.apache.org/jira/browse/AURORA-186
Repository: aurora
Description
-------
rename ThermosExecutor to AuroraExecutor, clean up thermos-isms from ExecutorBase
split all thermos-specific stuff out of thermos_executor.py
Diffs
-----
src/main/python/apache/aurora/executor/BUILD 667975b8064398b06d24edac1f9e0f6b180b79b1
src/main/python/apache/aurora/executor/__init__.py d54d88cc91172edbc8f5a35a40f66108fe4b5cfd
src/main/python/apache/aurora/executor/bin/BUILD 2dcc69b35166eefb9fe382798ab61861c6b5f5dd
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 8968e8943fe58c1be472e6e64720d6e9d77d377c
src/main/python/apache/aurora/executor/executor_base.py a1310cc74209b054a80be48381a5861b1a1a342f
src/main/python/apache/aurora/executor/gc_executor.py b8b502606ced1ef082f8cb2878e0d2bf23cbd6c1
src/main/python/apache/aurora/executor/thermos_executor.py 252ba5f17050495ee586c92e52f03bde5119a042
src/main/python/apache/aurora/executor/thermos_task_runner.py 8e18928eabb8c0a675bbca5b9305b99b89883a41
src/test/python/apache/aurora/executor/BUILD 3f2387fc6aa3d1f946c75189ae3c7e8c05847e50
src/test/python/apache/aurora/executor/test_thermos_executor.py 3810ea39a014bc0584b74b5e5f8af87a2fe370df
src/test/python/apache/thermos/common/BUILD 7bbd826de14bad545345fd698baebac602fe5a94
Diff: https://reviews.apache.org/r/18239/diff/
Testing
-------
this adds executor-small and executor-large, the latter of which runs the executor tests. ./pants src/test/python/apache/aurora/executor:executor-large -v passes for me locally. running e2e now.
Thanks,
Brian Wickman
Re: Review Request 18239: rename ThermosExecutor to AuroraExecutor,
clean up thermos-isms from ExecutorBase
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18239/#review35149
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On Feb. 18, 2014, 4:46 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18239/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 4:46 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-186
> https://issues.apache.org/jira/browse/AURORA-186
>
>
> Repository: aurora
>
>
> Description
> -------
>
> rename ThermosExecutor to AuroraExecutor, clean up thermos-isms from ExecutorBase
>
> split all thermos-specific stuff out of thermos_executor.py
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/BUILD 667975b8064398b06d24edac1f9e0f6b180b79b1
> src/main/python/apache/aurora/executor/__init__.py d54d88cc91172edbc8f5a35a40f66108fe4b5cfd
> src/main/python/apache/aurora/executor/bin/BUILD 2dcc69b35166eefb9fe382798ab61861c6b5f5dd
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 8968e8943fe58c1be472e6e64720d6e9d77d377c
> src/main/python/apache/aurora/executor/executor_base.py a1310cc74209b054a80be48381a5861b1a1a342f
> src/main/python/apache/aurora/executor/gc_executor.py b8b502606ced1ef082f8cb2878e0d2bf23cbd6c1
> src/main/python/apache/aurora/executor/thermos_executor.py 252ba5f17050495ee586c92e52f03bde5119a042
> src/main/python/apache/aurora/executor/thermos_task_runner.py 8e18928eabb8c0a675bbca5b9305b99b89883a41
> src/test/python/apache/aurora/executor/BUILD 3f2387fc6aa3d1f946c75189ae3c7e8c05847e50
> src/test/python/apache/aurora/executor/test_thermos_executor.py 3810ea39a014bc0584b74b5e5f8af87a2fe370df
> src/test/python/apache/thermos/common/BUILD 7bbd826de14bad545345fd698baebac602fe5a94
>
> Diff: https://reviews.apache.org/r/18239/diff/
>
>
> Testing
> -------
>
> this adds executor-small and executor-large, the latter of which runs the executor tests. ./pants src/test/python/apache/aurora/executor:executor-large -v passes for me locally. running e2e now.
>
>
> Thanks,
>
> Brian Wickman
>
>