You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/04/26 17:58:23 UTC

[GitHub] [maven-shared-utils] elharo opened a new pull request #86: avoid reusing fixtures

elharo opened a new pull request #86:
URL: https://github.com/apache/maven-shared-utils/pull/86


   @mthmulders 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] elharo commented on a change in pull request #86: avoid reusing fixtures

Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #86:
URL: https://github.com/apache/maven-shared-utils/pull/86#discussion_r620575581



##########
File path: src/test/java/org/apache/maven/shared/utils/xml/XmlWriterUtilTest.java
##########
@@ -86,7 +75,6 @@ public void testWriteLineBreakXMLWriterInt()
     {
         XmlWriterUtil.writeLineBreak( xmlWriter, 10 );
         writer.close();
-        assertTrue( StringUtils.countMatches( output.toString(), XmlWriterUtil.LS ) == 10 );

Review comment:
       done

##########
File path: src/test/java/org/apache/maven/shared/utils/xml/XmlWriterUtilTest.java
##########
@@ -86,7 +75,6 @@ public void testWriteLineBreakXMLWriterInt()
     {
         XmlWriterUtil.writeLineBreak( xmlWriter, 10 );
         writer.close();
-        assertTrue( StringUtils.countMatches( output.toString(), XmlWriterUtil.LS ) == 10 );

Review comment:
       nope, just an error. I'll fix it. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] elharo merged pull request #86: avoid reusing fixtures

Posted by GitBox <gi...@apache.org>.
elharo merged pull request #86:
URL: https://github.com/apache/maven-shared-utils/pull/86


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] mthmulders commented on a change in pull request #86: avoid reusing fixtures

Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #86:
URL: https://github.com/apache/maven-shared-utils/pull/86#discussion_r620565790



##########
File path: src/test/java/org/apache/maven/shared/utils/xml/XmlWriterUtilTest.java
##########
@@ -86,7 +75,6 @@ public void testWriteLineBreakXMLWriterInt()
     {
         XmlWriterUtil.writeLineBreak( xmlWriter, 10 );
         writer.close();
-        assertTrue( StringUtils.countMatches( output.toString(), XmlWriterUtil.LS ) == 10 );

Review comment:
       Did you remove the assertion on purpose? If so, why?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org