[GitHub] [accumulo] milleruntime commented on a change in pull request #2574: fixes #2567 corrects race condition in tablet metadata verification

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #2574:
URL: https://github.com/apache/accumulo/pull/2574#discussion_r831386046



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
##########
@@ -1435,23 +1439,34 @@ private void closeConsistencyCheck() {
     }
   }
 
-  private void compareToDataInMemory(TabletMetadata tabletMetadata) {
-    if (!tabletMetadata.getFilesMap().equals(getDatafileManager().getDatafileSizes())) {
-      String msg = "Data files in " + extent + " differ from in-memory data "
-          + tabletMetadata.getFilesMap() + " " + getDatafileManager().getDatafileSizes();
-      log.error(msg);
-    }
-  }
-
-  public synchronized void compareTabletInfo(Long updateCounter, TabletMetadata tabletMetadata) {
+  public synchronized void compareTabletInfo(MetadataUpdateCount updateCounter,
+      TabletMetadata tabletMetadata) {

Review comment:
       Does it matter which thread (the main thread vs during a close) is doing the check? This was one thing I was wondering while doing testing. If we add a boolean here of who is calling the check, we could bail if it is not the correct thread.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org