You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/06/10 06:02:49 UTC
[GitHub] [dubbo-getty] LaurenceLiZhixin commented on a diff in pull request #95: Fix: remove gost timer to fix high cpu usage problem
LaurenceLiZhixin commented on code in PR #95:
URL: https://github.com/apache/dubbo-getty/pull/95#discussion_r894179282
##########
session.go:
##########
@@ -551,9 +545,12 @@ func (s *session) run() {
return
}
- if _, err := defaultTimerWheel.AddTimer(heartbeat, gxtime.TimerLoop, s.period, s); err != nil {
- panic(fmt.Sprintf("failed to add session %s to defaultTimerWheel err:%v", s.Stat(), err))
- }
+ go func() {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org