You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Marco Gaido <ma...@gmail.com> on 2018/09/19 06:57:55 UTC
***UNCHECKED*** Re: [VOTE] SPARK 2.3.2 (RC6)
Sorry, I am -1 because of SPARK-25454 which is a regression from 2.2.
Il giorno mer 19 set 2018 alle ore 03:45 Dongjoon Hyun <
dongjoon.hyun@gmail.com> ha scritto:
> +1.
>
> I tested with `-Pyarn -Phadoop-2.7 -Pkinesis-asl -Phive
> -Phive-thriftserve` on OpenJDK(1.8.0_181)/CentOS 7.5.
>
> I hit the following test case failure once during testing, but it's not
> persistent.
>
> KafkaContinuousSourceSuite
> ...
> subscribing topic by name from earliest offsets (failOnDataLoss:
> false) *** FAILED ***
>
> Thank you, Saisai.
>
> Bests,
> Dongjoon.
>
> On Mon, Sep 17, 2018 at 6:48 PM Saisai Shao <sa...@gmail.com>
> wrote:
>
>> +1 from my own side.
>>
>> Thanks
>> Saisai
>>
>> Wenchen Fan <cl...@gmail.com> 于2018年9月18日周二 上午9:34写道：
>>
>>> +1. All the blocker issues are all resolved in 2.3.2 AFAIK.
>>>
>>> On Tue, Sep 18, 2018 at 9:23 AM Sean Owen <sr...@apache.org> wrote:
>>>
>>>> +1 . Licenses and sigs check out as in previous 2.3.x releases. A
>>>> build from source with most profiles passed for me.
>>>> On Mon, Sep 17, 2018 at 8:17 AM Saisai Shao <sa...@gmail.com>
>>>> wrote:
>>>> >
>>>> > Please vote on releasing the following candidate as Apache Spark
>>>> version 2.3.2.
>>>> >
>>>> > The vote is open until September 21 PST and passes if a majority +1
>>>> PMC votes are cast, with a minimum of 3 +1 votes.
>>>> >
>>>> > [ ] +1 Release this package as Apache Spark 2.3.2
>>>> > [ ] -1 Do not release this package because ...
>>>> >
>>>> > To learn more about Apache Spark, please see http://spark.apache.org/
>>>> >
>>>> > The tag to be voted on is v2.3.2-rc6 (commit
>>>> 02b510728c31b70e6035ad541bfcdc2b59dcd79a):
>>>> > https://github.com/apache/spark/tree/v2.3.2-rc6
>>>> >
>>>> > The release files, including signatures, digests, etc. can be found
>>>> at:
>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-bin/
>>>> >
>>>> > Signatures used for Spark RCs can be found in this file:
>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS
>>>> >
>>>> > The staging repository for this release can be found at:
>>>> >
>>>> https://repository.apache.org/content/repositories/orgapachespark-1286/
>>>> >
>>>> > The documentation corresponding to this release can be found at:
>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-docs/
>>>> >
>>>> > The list of bug fixes going into 2.3.2 can be found at the following
>>>> URL:
>>>> > https://issues.apache.org/jira/projects/SPARK/versions/12343289
>>>> >
>>>> >
>>>> > FAQ
>>>> >
>>>> > =========================
>>>> > How can I help test this release?
>>>> > =========================
>>>> >
>>>> > If you are a Spark user, you can help us test this release by taking
>>>> > an existing Spark workload and running on this release candidate, then
>>>> > reporting any regressions.
>>>> >
>>>> > If you're working in PySpark you can set up a virtual env and install
>>>> > the current RC and see if anything important breaks, in the Java/Scala
>>>> > you can add the staging repository to your projects resolvers and test
>>>> > with the RC (make sure to clean up the artifact cache before/after so
>>>> > you don't end up building with a out of date RC going forward).
>>>> >
>>>> > ===========================================
>>>> > What should happen to JIRA tickets still targeting 2.3.2?
>>>> > ===========================================
>>>> >
>>>> > The current list of open tickets targeted at 2.3.2 can be found at:
>>>> > https://issues.apache.org/jira/projects/SPARK and search for "Target
>>>> Version/s" = 2.3.2
>>>> >
>>>> > Committers should look at those and triage. Extremely important bug
>>>> > fixes, documentation, and API tweaks that impact compatibility should
>>>> > be worked on immediately. Everything else please retarget to an
>>>> > appropriate release.
>>>> >
>>>> > ==================
>>>> > But my bug isn't fixed?
>>>> > ==================
>>>> >
>>>> > In order to make timely releases, we will typically not hold the
>>>> > release unless the bug in question is a regression from the previous
>>>> > release. That being said, if there is something which is a regression
>>>> > that has not been correctly targeted please ping me or a committer to
>>>> > help target the issue.
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>>>
>>>>
***UNCHECKED*** Re: [VOTE] SPARK 2.3.2 (RC6)
Posted by Saisai Shao <sa...@gmail.com>.
Hi Marco,
From my understanding of SPARK-25454, I don't think it is a block issue, it
might be an corner case, so personally I don't want to block the release of
2.3.2 because of this issue. The release has been delayed for a long time.
Thanks
Saisai
Marco Gaido <ma...@gmail.com> 于2018年9月19日周三 下午2:58写道：
> Sorry, I am -1 because of SPARK-25454 which is a regression from 2.2.
>
> Il giorno mer 19 set 2018 alle ore 03:45 Dongjoon Hyun <
> dongjoon.hyun@gmail.com> ha scritto:
>
>> +1.
>>
>> I tested with `-Pyarn -Phadoop-2.7 -Pkinesis-asl -Phive
>> -Phive-thriftserve` on OpenJDK(1.8.0_181)/CentOS 7.5.
>>
>> I hit the following test case failure once during testing, but it's not
>> persistent.
>>
>> KafkaContinuousSourceSuite
>> ...
>> subscribing topic by name from earliest offsets (failOnDataLoss:
>> false) *** FAILED ***
>>
>> Thank you, Saisai.
>>
>> Bests,
>> Dongjoon.
>>
>> On Mon, Sep 17, 2018 at 6:48 PM Saisai Shao <sa...@gmail.com>
>> wrote:
>>
>>> +1 from my own side.
>>>
>>> Thanks
>>> Saisai
>>>
>>> Wenchen Fan <cl...@gmail.com> 于2018年9月18日周二 上午9:34写道：
>>>
>>>> +1. All the blocker issues are all resolved in 2.3.2 AFAIK.
>>>>
>>>> On Tue, Sep 18, 2018 at 9:23 AM Sean Owen <sr...@apache.org> wrote:
>>>>
>>>>> +1 . Licenses and sigs check out as in previous 2.3.x releases. A
>>>>> build from source with most profiles passed for me.
>>>>> On Mon, Sep 17, 2018 at 8:17 AM Saisai Shao <sa...@gmail.com>
>>>>> wrote:
>>>>> >
>>>>> > Please vote on releasing the following candidate as Apache Spark
>>>>> version 2.3.2.
>>>>> >
>>>>> > The vote is open until September 21 PST and passes if a majority +1
>>>>> PMC votes are cast, with a minimum of 3 +1 votes.
>>>>> >
>>>>> > [ ] +1 Release this package as Apache Spark 2.3.2
>>>>> > [ ] -1 Do not release this package because ...
>>>>> >
>>>>> > To learn more about Apache Spark, please see
>>>>> http://spark.apache.org/
>>>>> >
>>>>> > The tag to be voted on is v2.3.2-rc6 (commit
>>>>> 02b510728c31b70e6035ad541bfcdc2b59dcd79a):
>>>>> > https://github.com/apache/spark/tree/v2.3.2-rc6
>>>>> >
>>>>> > The release files, including signatures, digests, etc. can be found
>>>>> at:
>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-bin/
>>>>> >
>>>>> > Signatures used for Spark RCs can be found in this file:
>>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS
>>>>> >
>>>>> > The staging repository for this release can be found at:
>>>>> >
>>>>> https://repository.apache.org/content/repositories/orgapachespark-1286/
>>>>> >
>>>>> > The documentation corresponding to this release can be found at:
>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-docs/
>>>>> >
>>>>> > The list of bug fixes going into 2.3.2 can be found at the following
>>>>> URL:
>>>>> > https://issues.apache.org/jira/projects/SPARK/versions/12343289
>>>>> >
>>>>> >
>>>>> > FAQ
>>>>> >
>>>>> > =========================
>>>>> > How can I help test this release?
>>>>> > =========================
>>>>> >
>>>>> > If you are a Spark user, you can help us test this release by taking
>>>>> > an existing Spark workload and running on this release candidate,
>>>>> then
>>>>> > reporting any regressions.
>>>>> >
>>>>> > If you're working in PySpark you can set up a virtual env and install
>>>>> > the current RC and see if anything important breaks, in the
>>>>> Java/Scala
>>>>> > you can add the staging repository to your projects resolvers and
>>>>> test
>>>>> > with the RC (make sure to clean up the artifact cache before/after so
>>>>> > you don't end up building with a out of date RC going forward).
>>>>> >
>>>>> > ===========================================
>>>>> > What should happen to JIRA tickets still targeting 2.3.2?
>>>>> > ===========================================
>>>>> >
>>>>> > The current list of open tickets targeted at 2.3.2 can be found at:
>>>>> > https://issues.apache.org/jira/projects/SPARK and search for
>>>>> "Target Version/s" = 2.3.2
>>>>> >
>>>>> > Committers should look at those and triage. Extremely important bug
>>>>> > fixes, documentation, and API tweaks that impact compatibility should
>>>>> > be worked on immediately. Everything else please retarget to an
>>>>> > appropriate release.
>>>>> >
>>>>> > ==================
>>>>> > But my bug isn't fixed?
>>>>> > ==================
>>>>> >
>>>>> > In order to make timely releases, we will typically not hold the
>>>>> > release unless the bug in question is a regression from the previous
>>>>> > release. That being said, if there is something which is a regression
>>>>> > that has not been correctly targeted please ping me or a committer to
>>>>> > help target the issue.
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>>>>
>>>>>
Re: ***UNCHECKED*** Re: Re: Re: [VOTE] SPARK 2.3.2 (RC6)
Posted by Mark Hamstra <ma...@clearstorydata.com>.
That's overstated. We will also block for a data correctness issue -- and
that is, arguably, what this is.
On Wed, Sep 19, 2018 at 12:21 AM Reynold Xin <rx...@databricks.com> wrote:
> We also only block if it is a new regression.
>
> On Wed, Sep 19, 2018 at 12:18 AM Saisai Shao <sa...@gmail.com>
> wrote:
>
>> Hi Marco,
>>
>> From my understanding of SPARK-25454, I don't think it is a block issue,
>> it might be an corner case, so personally I don't want to block the release
>> of 2.3.2 because of this issue. The release has been delayed for a long
>> time.
>>
>> Marco Gaido <ma...@gmail.com> 于2018年9月19日周三 下午2:58写道：
>>
>>> Sorry, I am -1 because of SPARK-25454 which is a regression from 2.2.
>>>
>>> Il giorno mer 19 set 2018 alle ore 03:45 Dongjoon Hyun <
>>> dongjoon.hyun@gmail.com> ha scritto:
>>>
>>>> +1.
>>>>
>>>> I tested with `-Pyarn -Phadoop-2.7 -Pkinesis-asl -Phive
>>>> -Phive-thriftserve` on OpenJDK(1.8.0_181)/CentOS 7.5.
>>>>
>>>> I hit the following test case failure once during testing, but it's not
>>>> persistent.
>>>>
>>>> KafkaContinuousSourceSuite
>>>> ...
>>>> subscribing topic by name from earliest offsets (failOnDataLoss:
>>>> false) *** FAILED ***
>>>>
>>>> Thank you, Saisai.
>>>>
>>>> Bests,
>>>> Dongjoon.
>>>>
>>>> On Mon, Sep 17, 2018 at 6:48 PM Saisai Shao <sa...@gmail.com>
>>>> wrote:
>>>>
>>>>> +1 from my own side.
>>>>>
>>>>> Thanks
>>>>> Saisai
>>>>>
>>>>> Wenchen Fan <cl...@gmail.com> 于2018年9月18日周二 上午9:34写道：
>>>>>
>>>>>> +1. All the blocker issues are all resolved in 2.3.2 AFAIK.
>>>>>>
>>>>>> On Tue, Sep 18, 2018 at 9:23 AM Sean Owen <sr...@apache.org> wrote:
>>>>>>
>>>>>>> +1 . Licenses and sigs check out as in previous 2.3.x releases. A
>>>>>>> build from source with most profiles passed for me.
>>>>>>> On Mon, Sep 17, 2018 at 8:17 AM Saisai Shao <sa...@gmail.com>
>>>>>>> wrote:
>>>>>>> >
>>>>>>> > Please vote on releasing the following candidate as Apache Spark
>>>>>>> version 2.3.2.
>>>>>>> >
>>>>>>> > The vote is open until September 21 PST and passes if a majority
>>>>>>> +1 PMC votes are cast, with a minimum of 3 +1 votes.
>>>>>>> >
>>>>>>> > [ ] +1 Release this package as Apache Spark 2.3.2
>>>>>>> > [ ] -1 Do not release this package because ...
>>>>>>> >
>>>>>>> > To learn more about Apache Spark, please see
>>>>>>> http://spark.apache.org/
>>>>>>> >
>>>>>>> > The tag to be voted on is v2.3.2-rc6 (commit
>>>>>>> 02b510728c31b70e6035ad541bfcdc2b59dcd79a):
>>>>>>> > https://github.com/apache/spark/tree/v2.3.2-rc6
>>>>>>> >
>>>>>>> > The release files, including signatures, digests, etc. can be
>>>>>>> found at:
>>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-bin/
>>>>>>> >
>>>>>>> > Signatures used for Spark RCs can be found in this file:
>>>>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS
>>>>>>> >
>>>>>>> > The staging repository for this release can be found at:
>>>>>>> >
>>>>>>> https://repository.apache.org/content/repositories/orgapachespark-1286/
>>>>>>> >
>>>>>>> > The documentation corresponding to this release can be found at:
>>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-docs/
>>>>>>> >
>>>>>>> > The list of bug fixes going into 2.3.2 can be found at the
>>>>>>> following URL:
>>>>>>> > https://issues.apache.org/jira/projects/SPARK/versions/12343289
>>>>>>> >
>>>>>>> >
>>>>>>> > FAQ
>>>>>>> >
>>>>>>> > =========================
>>>>>>> > How can I help test this release?
>>>>>>> > =========================
>>>>>>> >
>>>>>>> > If you are a Spark user, you can help us test this release by
>>>>>>> taking
>>>>>>> > an existing Spark workload and running on this release candidate,
>>>>>>> then
>>>>>>> > reporting any regressions.
>>>>>>> >
>>>>>>> > If you're working in PySpark you can set up a virtual env and
>>>>>>> install
>>>>>>> > the current RC and see if anything important breaks, in the
>>>>>>> Java/Scala
>>>>>>> > you can add the staging repository to your projects resolvers and
>>>>>>> test
>>>>>>> > with the RC (make sure to clean up the artifact cache before/after
>>>>>>> so
>>>>>>> > you don't end up building with a out of date RC going forward).
>>>>>>> >
>>>>>>> > ===========================================
>>>>>>> > What should happen to JIRA tickets still targeting 2.3.2?
>>>>>>> > ===========================================
>>>>>>> >
>>>>>>> > The current list of open tickets targeted at 2.3.2 can be found at:
>>>>>>> > https://issues.apache.org/jira/projects/SPARK and search for
>>>>>>> "Target Version/s" = 2.3.2
>>>>>>> >
>>>>>>> > Committers should look at those and triage. Extremely important bug
>>>>>>> > fixes, documentation, and API tweaks that impact compatibility
>>>>>>> should
>>>>>>> > be worked on immediately. Everything else please retarget to an
>>>>>>> > appropriate release.
>>>>>>> >
>>>>>>> > ==================
>>>>>>> > But my bug isn't fixed?
>>>>>>> > ==================
>>>>>>> >
>>>>>>> > In order to make timely releases, we will typically not hold the
>>>>>>> > release unless the bug in question is a regression from the
>>>>>>> previous
>>>>>>> > release. That being said, if there is something which is a
>>>>>>> regression
>>>>>>> > that has not been correctly targeted please ping me or a committer
>>>>>>> to
>>>>>>> > help target the issue.
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>>>>>>
>>>>>>> --
> --
> excuse the brevity and lower case due to wrist injury
>
***UNCHECKED*** Re: Re: Re: Re: [VOTE] SPARK 2.3.2 (RC6)
Posted by Marco Gaido <ma...@gmail.com>.
It is not new, it has been there since 2.3.0, so in that case this is not a
blocker. Thanks.
Il giorno mer 19 set 2018 alle ore 09:21 Reynold Xin <rx...@databricks.com>
ha scritto:
> We also only block if it is a new regression.
>
> On Wed, Sep 19, 2018 at 12:18 AM Saisai Shao <sa...@gmail.com>
> wrote:
>
>> Hi Marco,
>>
>> From my understanding of SPARK-25454, I don't think it is a block issue,
>> it might be an corner case, so personally I don't want to block the release
>> of 2.3.2 because of this issue. The release has been delayed for a long
>> time.
>>
>> Marco Gaido <ma...@gmail.com> 于2018年9月19日周三 下午2:58写道：
>>
>>> Sorry, I am -1 because of SPARK-25454 which is a regression from 2.2.
>>>
>>> Il giorno mer 19 set 2018 alle ore 03:45 Dongjoon Hyun <
>>> dongjoon.hyun@gmail.com> ha scritto:
>>>
>>>> +1.
>>>>
>>>> I tested with `-Pyarn -Phadoop-2.7 -Pkinesis-asl -Phive
>>>> -Phive-thriftserve` on OpenJDK(1.8.0_181)/CentOS 7.5.
>>>>
>>>> I hit the following test case failure once during testing, but it's not
>>>> persistent.
>>>>
>>>> KafkaContinuousSourceSuite
>>>> ...
>>>> subscribing topic by name from earliest offsets (failOnDataLoss:
>>>> false) *** FAILED ***
>>>>
>>>> Thank you, Saisai.
>>>>
>>>> Bests,
>>>> Dongjoon.
>>>>
>>>> On Mon, Sep 17, 2018 at 6:48 PM Saisai Shao <sa...@gmail.com>
>>>> wrote:
>>>>
>>>>> +1 from my own side.
>>>>>
>>>>> Thanks
>>>>> Saisai
>>>>>
>>>>> Wenchen Fan <cl...@gmail.com> 于2018年9月18日周二 上午9:34写道：
>>>>>
>>>>>> +1. All the blocker issues are all resolved in 2.3.2 AFAIK.
>>>>>>
>>>>>> On Tue, Sep 18, 2018 at 9:23 AM Sean Owen <sr...@apache.org> wrote:
>>>>>>
>>>>>>> +1 . Licenses and sigs check out as in previous 2.3.x releases. A
>>>>>>> build from source with most profiles passed for me.
>>>>>>> On Mon, Sep 17, 2018 at 8:17 AM Saisai Shao <sa...@gmail.com>
>>>>>>> wrote:
>>>>>>> >
>>>>>>> > Please vote on releasing the following candidate as Apache Spark
>>>>>>> version 2.3.2.
>>>>>>> >
>>>>>>> > The vote is open until September 21 PST and passes if a majority
>>>>>>> +1 PMC votes are cast, with a minimum of 3 +1 votes.
>>>>>>> >
>>>>>>> > [ ] +1 Release this package as Apache Spark 2.3.2
>>>>>>> > [ ] -1 Do not release this package because ...
>>>>>>> >
>>>>>>> > To learn more about Apache Spark, please see
>>>>>>> http://spark.apache.org/
>>>>>>> >
>>>>>>> > The tag to be voted on is v2.3.2-rc6 (commit
>>>>>>> 02b510728c31b70e6035ad541bfcdc2b59dcd79a):
>>>>>>> > https://github.com/apache/spark/tree/v2.3.2-rc6
>>>>>>> >
>>>>>>> > The release files, including signatures, digests, etc. can be
>>>>>>> found at:
>>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-bin/
>>>>>>> >
>>>>>>> > Signatures used for Spark RCs can be found in this file:
>>>>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS
>>>>>>> >
>>>>>>> > The staging repository for this release can be found at:
>>>>>>> >
>>>>>>> https://repository.apache.org/content/repositories/orgapachespark-1286/
>>>>>>> >
>>>>>>> > The documentation corresponding to this release can be found at:
>>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-docs/
>>>>>>> >
>>>>>>> > The list of bug fixes going into 2.3.2 can be found at the
>>>>>>> following URL:
>>>>>>> > https://issues.apache.org/jira/projects/SPARK/versions/12343289
>>>>>>> >
>>>>>>> >
>>>>>>> > FAQ
>>>>>>> >
>>>>>>> > =========================
>>>>>>> > How can I help test this release?
>>>>>>> > =========================
>>>>>>> >
>>>>>>> > If you are a Spark user, you can help us test this release by
>>>>>>> taking
>>>>>>> > an existing Spark workload and running on this release candidate,
>>>>>>> then
>>>>>>> > reporting any regressions.
>>>>>>> >
>>>>>>> > If you're working in PySpark you can set up a virtual env and
>>>>>>> install
>>>>>>> > the current RC and see if anything important breaks, in the
>>>>>>> Java/Scala
>>>>>>> > you can add the staging repository to your projects resolvers and
>>>>>>> test
>>>>>>> > with the RC (make sure to clean up the artifact cache before/after
>>>>>>> so
>>>>>>> > you don't end up building with a out of date RC going forward).
>>>>>>> >
>>>>>>> > ===========================================
>>>>>>> > What should happen to JIRA tickets still targeting 2.3.2?
>>>>>>> > ===========================================
>>>>>>> >
>>>>>>> > The current list of open tickets targeted at 2.3.2 can be found at:
>>>>>>> > https://issues.apache.org/jira/projects/SPARK and search for
>>>>>>> "Target Version/s" = 2.3.2
>>>>>>> >
>>>>>>> > Committers should look at those and triage. Extremely important bug
>>>>>>> > fixes, documentation, and API tweaks that impact compatibility
>>>>>>> should
>>>>>>> > be worked on immediately. Everything else please retarget to an
>>>>>>> > appropriate release.
>>>>>>> >
>>>>>>> > ==================
>>>>>>> > But my bug isn't fixed?
>>>>>>> > ==================
>>>>>>> >
>>>>>>> > In order to make timely releases, we will typically not hold the
>>>>>>> > release unless the bug in question is a regression from the
>>>>>>> previous
>>>>>>> > release. That being said, if there is something which is a
>>>>>>> regression
>>>>>>> > that has not been correctly targeted please ping me or a committer
>>>>>>> to
>>>>>>> > help target the issue.
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>>>>>>
>>>>>>> --
> --
> excuse the brevity and lower case due to wrist injury
>
***UNCHECKED*** Re: Re: Re: [VOTE] SPARK 2.3.2 (RC6)
Posted by Reynold Xin <rx...@databricks.com>.
We also only block if it is a new regression.
On Wed, Sep 19, 2018 at 12:18 AM Saisai Shao <sa...@gmail.com> wrote:
> Hi Marco,
>
> From my understanding of SPARK-25454, I don't think it is a block issue,
> it might be an corner case, so personally I don't want to block the release
> of 2.3.2 because of this issue. The release has been delayed for a long
> time.
>
> Marco Gaido <ma...@gmail.com> 于2018年9月19日周三 下午2:58写道：
>
>> Sorry, I am -1 because of SPARK-25454 which is a regression from 2.2.
>>
>> Il giorno mer 19 set 2018 alle ore 03:45 Dongjoon Hyun <
>> dongjoon.hyun@gmail.com> ha scritto:
>>
>>> +1.
>>>
>>> I tested with `-Pyarn -Phadoop-2.7 -Pkinesis-asl -Phive
>>> -Phive-thriftserve` on OpenJDK(1.8.0_181)/CentOS 7.5.
>>>
>>> I hit the following test case failure once during testing, but it's not
>>> persistent.
>>>
>>> KafkaContinuousSourceSuite
>>> ...
>>> subscribing topic by name from earliest offsets (failOnDataLoss:
>>> false) *** FAILED ***
>>>
>>> Thank you, Saisai.
>>>
>>> Bests,
>>> Dongjoon.
>>>
>>> On Mon, Sep 17, 2018 at 6:48 PM Saisai Shao <sa...@gmail.com>
>>> wrote:
>>>
>>>> +1 from my own side.
>>>>
>>>> Thanks
>>>> Saisai
>>>>
>>>> Wenchen Fan <cl...@gmail.com> 于2018年9月18日周二 上午9:34写道：
>>>>
>>>>> +1. All the blocker issues are all resolved in 2.3.2 AFAIK.
>>>>>
>>>>> On Tue, Sep 18, 2018 at 9:23 AM Sean Owen <sr...@apache.org> wrote:
>>>>>
>>>>>> +1 . Licenses and sigs check out as in previous 2.3.x releases. A
>>>>>> build from source with most profiles passed for me.
>>>>>> On Mon, Sep 17, 2018 at 8:17 AM Saisai Shao <sa...@gmail.com>
>>>>>> wrote:
>>>>>> >
>>>>>> > Please vote on releasing the following candidate as Apache Spark
>>>>>> version 2.3.2.
>>>>>> >
>>>>>> > The vote is open until September 21 PST and passes if a majority +1
>>>>>> PMC votes are cast, with a minimum of 3 +1 votes.
>>>>>> >
>>>>>> > [ ] +1 Release this package as Apache Spark 2.3.2
>>>>>> > [ ] -1 Do not release this package because ...
>>>>>> >
>>>>>> > To learn more about Apache Spark, please see
>>>>>> http://spark.apache.org/
>>>>>> >
>>>>>> > The tag to be voted on is v2.3.2-rc6 (commit
>>>>>> 02b510728c31b70e6035ad541bfcdc2b59dcd79a):
>>>>>> > https://github.com/apache/spark/tree/v2.3.2-rc6
>>>>>> >
>>>>>> > The release files, including signatures, digests, etc. can be found
>>>>>> at:
>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-bin/
>>>>>> >
>>>>>> > Signatures used for Spark RCs can be found in this file:
>>>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS
>>>>>> >
>>>>>> > The staging repository for this release can be found at:
>>>>>> >
>>>>>> https://repository.apache.org/content/repositories/orgapachespark-1286/
>>>>>> >
>>>>>> > The documentation corresponding to this release can be found at:
>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-docs/
>>>>>> >
>>>>>> > The list of bug fixes going into 2.3.2 can be found at the
>>>>>> following URL:
>>>>>> > https://issues.apache.org/jira/projects/SPARK/versions/12343289
>>>>>> >
>>>>>> >
>>>>>> > FAQ
>>>>>> >
>>>>>> > =========================
>>>>>> > How can I help test this release?
>>>>>> > =========================
>>>>>> >
>>>>>> > If you are a Spark user, you can help us test this release by taking
>>>>>> > an existing Spark workload and running on this release candidate,
>>>>>> then
>>>>>> > reporting any regressions.
>>>>>> >
>>>>>> > If you're working in PySpark you can set up a virtual env and
>>>>>> install
>>>>>> > the current RC and see if anything important breaks, in the
>>>>>> Java/Scala
>>>>>> > you can add the staging repository to your projects resolvers and
>>>>>> test
>>>>>> > with the RC (make sure to clean up the artifact cache before/after
>>>>>> so
>>>>>> > you don't end up building with a out of date RC going forward).
>>>>>> >
>>>>>> > ===========================================
>>>>>> > What should happen to JIRA tickets still targeting 2.3.2?
>>>>>> > ===========================================
>>>>>> >
>>>>>> > The current list of open tickets targeted at 2.3.2 can be found at:
>>>>>> > https://issues.apache.org/jira/projects/SPARK and search for
>>>>>> "Target Version/s" = 2.3.2
>>>>>> >
>>>>>> > Committers should look at those and triage. Extremely important bug
>>>>>> > fixes, documentation, and API tweaks that impact compatibility
>>>>>> should
>>>>>> > be worked on immediately. Everything else please retarget to an
>>>>>> > appropriate release.
>>>>>> >
>>>>>> > ==================
>>>>>> > But my bug isn't fixed?
>>>>>> > ==================
>>>>>> >
>>>>>> > In order to make timely releases, we will typically not hold the
>>>>>> > release unless the bug in question is a regression from the previous
>>>>>> > release. That being said, if there is something which is a
>>>>>> regression
>>>>>> > that has not been correctly targeted please ping me or a committer
>>>>>> to
>>>>>> > help target the issue.
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>>>>>
>>>>>> --
--
excuse the brevity and lower case due to wrist injury
Re: ***UNCHECKED*** Re: [VOTE] SPARK 2.3.2 (RC6)
Posted by Sean Owen <sr...@apache.org>.
If the issue also existed in 2.3.1, then it should not block this
release. It can of course be fixed for a future 2.3.3.
On Wed, Sep 19, 2018 at 2:18 AM Saisai Shao <sa...@gmail.com> wrote:
>
> Hi Marco,
>
> From my understanding of SPARK-25454, I don't think it is a block issue, it might be an corner case, so personally I don't want to block the release of 2.3.2 because of this issue. The release has been delayed for a long time.
>
> Marco Gaido <ma...@gmail.com> 于2018年9月19日周三 下午2:58写道：
>>
>> Sorry, I am -1 because of SPARK-25454 which is a regression from 2.2.
>>
>> Il giorno mer 19 set 2018 alle ore 03:45 Dongjoon Hyun <do...@gmail.com> ha scritto:
>>>
>>> +1.
>>>
>>> I tested with `-Pyarn -Phadoop-2.7 -Pkinesis-asl -Phive -Phive-thriftserve` on OpenJDK(1.8.0_181)/CentOS 7.5.
>>>
>>> I hit the following test case failure once during testing, but it's not persistent.
>>>
>>> KafkaContinuousSourceSuite
>>> ...
>>> subscribing topic by name from earliest offsets (failOnDataLoss: false) *** FAILED ***
>>>
>>> Thank you, Saisai.
>>>
>>> Bests,
>>> Dongjoon.
>>>
>>> On Mon, Sep 17, 2018 at 6:48 PM Saisai Shao <sa...@gmail.com> wrote:
>>>>
>>>> +1 from my own side.
>>>>
>>>> Thanks
>>>> Saisai
>>>>
>>>> Wenchen Fan <cl...@gmail.com> 于2018年9月18日周二 上午9:34写道：
>>>>>
>>>>> +1. All the blocker issues are all resolved in 2.3.2 AFAIK.
>>>>>
>>>>> On Tue, Sep 18, 2018 at 9:23 AM Sean Owen <sr...@apache.org> wrote:
>>>>>>
>>>>>> +1 . Licenses and sigs check out as in previous 2.3.x releases. A
>>>>>> build from source with most profiles passed for me.
>>>>>> On Mon, Sep 17, 2018 at 8:17 AM Saisai Shao <sa...@gmail.com> wrote:
>>>>>> >
>>>>>> > Please vote on releasing the following candidate as Apache Spark version 2.3.2.
>>>>>> >
>>>>>> > The vote is open until September 21 PST and passes if a majority +1 PMC votes are cast, with a minimum of 3 +1 votes.
>>>>>> >
>>>>>> > [ ] +1 Release this package as Apache Spark 2.3.2
>>>>>> > [ ] -1 Do not release this package because ...
>>>>>> >
>>>>>> > To learn more about Apache Spark, please see http://spark.apache.org/
>>>>>> >
>>>>>> > The tag to be voted on is v2.3.2-rc6 (commit 02b510728c31b70e6035ad541bfcdc2b59dcd79a):
>>>>>> > https://github.com/apache/spark/tree/v2.3.2-rc6
>>>>>> >
>>>>>> > The release files, including signatures, digests, etc. can be found at:
>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-bin/
>>>>>> >
>>>>>> > Signatures used for Spark RCs can be found in this file:
>>>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS
>>>>>> >
>>>>>> > The staging repository for this release can be found at:
>>>>>> > https://repository.apache.org/content/repositories/orgapachespark-1286/
>>>>>> >
>>>>>> > The documentation corresponding to this release can be found at:
>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-docs/
>>>>>> >
>>>>>> > The list of bug fixes going into 2.3.2 can be found at the following URL:
>>>>>> > https://issues.apache.org/jira/projects/SPARK/versions/12343289
>>>>>> >
>>>>>> >
>>>>>> > FAQ
>>>>>> >
>>>>>> > =========================
>>>>>> > How can I help test this release?
>>>>>> > =========================
>>>>>> >
>>>>>> > If you are a Spark user, you can help us test this release by taking
>>>>>> > an existing Spark workload and running on this release candidate, then
>>>>>> > reporting any regressions.
>>>>>> >
>>>>>> > If you're working in PySpark you can set up a virtual env and install
>>>>>> > the current RC and see if anything important breaks, in the Java/Scala
>>>>>> > you can add the staging repository to your projects resolvers and test
>>>>>> > with the RC (make sure to clean up the artifact cache before/after so
>>>>>> > you don't end up building with a out of date RC going forward).
>>>>>> >
>>>>>> > ===========================================
>>>>>> > What should happen to JIRA tickets still targeting 2.3.2?
>>>>>> > ===========================================
>>>>>> >
>>>>>> > The current list of open tickets targeted at 2.3.2 can be found at:
>>>>>> > https://issues.apache.org/jira/projects/SPARK and search for "Target Version/s" = 2.3.2
>>>>>> >
>>>>>> > Committers should look at those and triage. Extremely important bug
>>>>>> > fixes, documentation, and API tweaks that impact compatibility should
>>>>>> > be worked on immediately. Everything else please retarget to an
>>>>>> > appropriate release.
>>>>>> >
>>>>>> > ==================
>>>>>> > But my bug isn't fixed?
>>>>>> > ==================
>>>>>> >
>>>>>> > In order to make timely releases, we will typically not hold the
>>>>>> > release unless the bug in question is a regression from the previous
>>>>>> > release. That being said, if there is something which is a regression
>>>>>> > that has not been correctly targeted please ping me or a committer to
>>>>>> > help target the issue.
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>>>>>
---------------------------------------------------------------------
To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
***UNCHECKED*** Re: Re: [VOTE] SPARK 2.3.2 (RC6)
Posted by Saisai Shao <sa...@gmail.com>.
Hi Marco,
From my understanding of SPARK-25454, I don't think it is a block issue, it
might be an corner case, so personally I don't want to block the release of
2.3.2 because of this issue. The release has been delayed for a long time.
Marco Gaido <ma...@gmail.com> 于2018年9月19日周三 下午2:58写道：
> Sorry, I am -1 because of SPARK-25454 which is a regression from 2.2.
>
> Il giorno mer 19 set 2018 alle ore 03:45 Dongjoon Hyun <
> dongjoon.hyun@gmail.com> ha scritto:
>
>> +1.
>>
>> I tested with `-Pyarn -Phadoop-2.7 -Pkinesis-asl -Phive
>> -Phive-thriftserve` on OpenJDK(1.8.0_181)/CentOS 7.5.
>>
>> I hit the following test case failure once during testing, but it's not
>> persistent.
>>
>> KafkaContinuousSourceSuite
>> ...
>> subscribing topic by name from earliest offsets (failOnDataLoss:
>> false) *** FAILED ***
>>
>> Thank you, Saisai.
>>
>> Bests,
>> Dongjoon.
>>
>> On Mon, Sep 17, 2018 at 6:48 PM Saisai Shao <sa...@gmail.com>
>> wrote:
>>
>>> +1 from my own side.
>>>
>>> Thanks
>>> Saisai
>>>
>>> Wenchen Fan <cl...@gmail.com> 于2018年9月18日周二 上午9:34写道：
>>>
>>>> +1. All the blocker issues are all resolved in 2.3.2 AFAIK.
>>>>
>>>> On Tue, Sep 18, 2018 at 9:23 AM Sean Owen <sr...@apache.org> wrote:
>>>>
>>>>> +1 . Licenses and sigs check out as in previous 2.3.x releases. A
>>>>> build from source with most profiles passed for me.
>>>>> On Mon, Sep 17, 2018 at 8:17 AM Saisai Shao <sa...@gmail.com>
>>>>> wrote:
>>>>> >
>>>>> > Please vote on releasing the following candidate as Apache Spark
>>>>> version 2.3.2.
>>>>> >
>>>>> > The vote is open until September 21 PST and passes if a majority +1
>>>>> PMC votes are cast, with a minimum of 3 +1 votes.
>>>>> >
>>>>> > [ ] +1 Release this package as Apache Spark 2.3.2
>>>>> > [ ] -1 Do not release this package because ...
>>>>> >
>>>>> > To learn more about Apache Spark, please see
>>>>> http://spark.apache.org/
>>>>> >
>>>>> > The tag to be voted on is v2.3.2-rc6 (commit
>>>>> 02b510728c31b70e6035ad541bfcdc2b59dcd79a):
>>>>> > https://github.com/apache/spark/tree/v2.3.2-rc6
>>>>> >
>>>>> > The release files, including signatures, digests, etc. can be found
>>>>> at:
>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-bin/
>>>>> >
>>>>> > Signatures used for Spark RCs can be found in this file:
>>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS
>>>>> >
>>>>> > The staging repository for this release can be found at:
>>>>> >
>>>>> https://repository.apache.org/content/repositories/orgapachespark-1286/
>>>>> >
>>>>> > The documentation corresponding to this release can be found at:
>>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.2-rc6-docs/
>>>>> >
>>>>> > The list of bug fixes going into 2.3.2 can be found at the following
>>>>> URL:
>>>>> > https://issues.apache.org/jira/projects/SPARK/versions/12343289
>>>>> >
>>>>> >
>>>>> > FAQ
>>>>> >
>>>>> > =========================
>>>>> > How can I help test this release?
>>>>> > =========================
>>>>> >
>>>>> > If you are a Spark user, you can help us test this release by taking
>>>>> > an existing Spark workload and running on this release candidate,
>>>>> then
>>>>> > reporting any regressions.
>>>>> >
>>>>> > If you're working in PySpark you can set up a virtual env and install
>>>>> > the current RC and see if anything important breaks, in the
>>>>> Java/Scala
>>>>> > you can add the staging repository to your projects resolvers and
>>>>> test
>>>>> > with the RC (make sure to clean up the artifact cache before/after so
>>>>> > you don't end up building with a out of date RC going forward).
>>>>> >
>>>>> > ===========================================
>>>>> > What should happen to JIRA tickets still targeting 2.3.2?
>>>>> > ===========================================
>>>>> >
>>>>> > The current list of open tickets targeted at 2.3.2 can be found at:
>>>>> > https://issues.apache.org/jira/projects/SPARK and search for
>>>>> "Target Version/s" = 2.3.2
>>>>> >
>>>>> > Committers should look at those and triage. Extremely important bug
>>>>> > fixes, documentation, and API tweaks that impact compatibility should
>>>>> > be worked on immediately. Everything else please retarget to an
>>>>> > appropriate release.
>>>>> >
>>>>> > ==================
>>>>> > But my bug isn't fixed?
>>>>> > ==================
>>>>> >
>>>>> > In order to make timely releases, we will typically not hold the
>>>>> > release unless the bug in question is a regression from the previous
>>>>> > release. That being said, if there is something which is a regression
>>>>> > that has not been correctly targeted please ping me or a committer to
>>>>> > help target the issue.
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>>>>
>>>>>