You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/08 07:35:20 UTC

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

YuuichiNakamura commented on a change in pull request #421:
URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r501507319



##########
File path: nshlib/nsh_command.c
##########
@@ -518,6 +518,18 @@ static const struct cmdmap_s g_cmdmap[] =
   { "time",     cmd_time,     2, 2, "\"<command>\"" },
 #endif
 
+#ifdef CONFIG_DRIVER_NOTECTL
+# ifndef CONFIG_NSH_DISABLE_TRACE
+  { "trace",    cmd_trace,    1, CONFIG_NSH_MAXARGUMENTS,

Review comment:
       To say the truth, I troubled what command name should be given to this feature.
   As you mentioned, this feature strongly depends on note of the kernel function, but "note" command already exists at apps/system/sched_note, and from the user point of view, the feature realized by this command is truly task trace.
   So I decided to name "trace" to this feature.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org