[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #12821: feat(sankey): provide layout with unequal input and output paths

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #12821:
URL: https://github.com/apache/incubator-echarts/pull/12821#discussion_r442010563



##########
File path: src/chart/sankey/sankeyLayout.js
##########
@@ -28,6 +28,8 @@ export default function (ecModel, api, payload) {
         var nodeWidth = seriesModel.get('nodeWidth');
         var nodeGap = seriesModel.get('nodeGap');
 
+        var mode = seriesModel.get('mode') || 'normal';

Review comment:
       You should probably set default mode in `SankeySeries.js` rather than using `|| 'normal'`.

##########
File path: src/chart/sankey/SankeyView.js
##########
@@ -61,38 +61,60 @@ function fadeInItem(item, opacityPath) {
     el.highlight && el.highlight();
 }
 
+function sum(array, cb, orient) {
+  var sum = 0;

Review comment:
       Please use 4 spaces for indent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org