Re: [PR] CASSANDRA-19831: Clarify off-heap OOM error msg [cassandra]

["driftx (via GitHub)" <gi...@apache.org>]

driftx commented on code in PR #4916:
URL: https://github.com/apache/cassandra/pull/4916#discussion_r3704262179


##########
src/java/org/apache/cassandra/utils/JVMStabilityInspector.java:
##########
@@ -200,7 +200,7 @@ private static void forceHeapSpaceOomMaybe(OutOfMemoryError oom)
     {
         if (FORCE_HEAP_OOM_IGNORE_SET.contains(oom.getMessage()))
             return;
-        logger.error("Force heap space OutOfMemoryError in the presence of", oom);
+        logger.error("Non-heap OutOfMemoryError detected, forcing a heap OutOfMemoryError to trigger standard JVM OOM handling:", oom);

Review Comment:
   The docstring says this but doesn't enforce it.  If we try to allocate a huge array for instance, it will throw "Requested array size exceeds VM limit" and this will throw OutOfMemoryError but won't be an off-heap issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org