You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/17 18:13:10 UTC

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB
URL: https://github.com/apache/couchdb/pull/2585#discussion_r393844954
 
 

 ##########
 File path: src/chttpd/src/chttpd_db.erl
 ##########
 @@ -984,7 +956,8 @@ apply_args_to_keylist(Args, Keys0) ->
 view_cb({row, Row}, {iter, Db, Args, VAcc}) ->
     NewRow = case lists:keymember(doc, 1, Row) of
         true ->
-            chttpd_stats:incr_reads();
+            chttpd_stats:incr_reads(),
+            Row;
 
 Review comment:
   No, the `false when Args#mrargs.include_docs` check was added in the fdb-layer code and is the reason this needed to be changed to return a row.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services