[jira] Commented: (XALANJ-2114) odd non-shortcircuited boolean logic

["John Gentilin (JIRA)" <xa...@xml.apache.org>]

    [ http://issues.apache.org/jira/browse/XALANJ-2114?page=comments#action_12315782 ] 

John Gentilin commented on XALANJ-2114:
---------------------------------------

I reviewed the code and found no reason that the logical operators should not be used, modified the code, created a patch and verified that no adverse effect were made to smoketest.
The patch has been attached.

> odd non-shortcircuited boolean logic
> ------------------------------------
>
>          Key: XALANJ-2114
>          URL: http://issues.apache.org/jira/browse/XALANJ-2114
>      Project: XalanJ2
>         Type: Bug
>     Versions: CurrentCVS
>  Environment: win32 xp
>     Reporter: Dave Brosius
>     Assignee: John Gentilin
>     Priority: Minor
>      Fix For: 2.7.0-future-release
>  Attachments: JIRA2114-patch.zip
>
> In class: org.apache.xpath.objects.XString
> In method: public double toDouble()
> Using non short-circuited logic operators.... Is this on purpose?
> if (c != '-' & c != '.' & ( c < 0X30 | c > 0x39)) {
> ------------------------------------------------------------
> Also in class: org.apache.xml.dtm.ref.DTMDefaultBase
> In method: public boolean isNodeAfter(int nodeHandle1, int nodeHandle2)
>     return index1!=NULL & index2!=NULL & index1 <= index2;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org