Re: svn commit: r12859 - trunk/subversion/clients/cmdline

[kf...@collab.net]

julianfoad@tigris.org writes:
> Log:
> Fix the encoding of XML output from "svn list --xml": output it as UTF-8.
> 
> * subversion/clients/cmdline/log-cmd.c
>   (error_checked_fputs): Extracted and made semi-public with svn_cl__ prefix.
>   (log_message_receiver_xml, svn_cl__log): Adjust calls accordingly.
> 
> * subversion/clients/cmdline/cl.h
> * subversion/clients/cmdline/util.c
>   (svn_cl__error_checked_fputs): New; was log-cmd.c::error_checked_fputs.
> 
> * subversion/clients/cmdline/ls-cmd.c
>   (print_header_xml, print_footer_xml): New helper functions, for tidiness.
>   (print_dirents_xml, svn_cl__ls): Avoid converting UTF-8 to native encoding
>     when writing XML output.
> 
> 
> Modified: trunk/subversion/clients/cmdline/cl.h
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/clients/cmdline/cl.h?view=diff&rev=12859&p1=trunk/subversion/clients/cmdline/cl.h&r1=12858&p2=trunk/subversion/clients/cmdline/cl.h&r2=12859
> ==============================================================================
> --- trunk/subversion/clients/cmdline/cl.h	(original)
> +++ trunk/subversion/clients/cmdline/cl.h	Wed Jan 26 12:30:52 2005
> @@ -434,6 +434,10 @@
>  /* Add a message about --force if appropriate */
>  svn_error_t *svn_cl__may_need_force (svn_error_t *err);
>  
> +/* Write the STRING to the stdio STREAM, returning an error if it fails. */
> +svn_error_t *svn_cl__error_checked_fputs (const char *string,
> +                                          FILE* stream);
> +

We usually write "FILE *stream", w/ space before star instead of after.

Didn't see anything suspicious in the rest of the commit.  Thanks for
doing this!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12859 - trunk/subversion/clients/cmdline

[Julian Foad <ju...@btopenworld.com>]

kfogel@collab.net wrote:
>>+svn_error_t *svn_cl__error_checked_fputs (const char *string,
>>+                                          FILE* stream);
> 
> We usually write "FILE *stream", w/ space before star instead of after.

Oh yes.  And in the implementation file too.  I just moved existing code, 
noticing that it needed a space before the opening parenthesis, but not 
noticing that.  It's not worth a separate commit just to fix that.

> Didn't see anything suspicious in the rest of the commit.  Thanks for
> doing this!

Thanks for the review.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org