Re: [PR] KAFKA-17109: Reduce log message load for failed locking [kafka]

["cadonna (via GitHub)" <gi...@apache.org>]

cadonna commented on code in PR #16705:
URL: https://github.com/apache/kafka/pull/16705#discussion_r1713907490


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -1011,7 +1011,7 @@ private void addTaskToStateUpdater(final Task task) {
         } catch (final LockException lockException) {
             // The state directory may still be locked by another thread, when the rebalance just happened.
             // Retry in the next iteration.
-            log.info("Encountered lock exception. Reattempting locking the state in the next iteration.", lockException);
+            log.debug("Encountered lock exception. Reattempting locking the state in the next iteration.");

Review Comment:
   If you remove the exception from the log message, we lose the info about to which task this lock exception belongs. So either you add only the message of the `LockException` to the log message or you add the task ID from `task`. I would prefer the former. Something like:
    ```suggestion
                log.debug("Encountered lock exception. Reattempting locking the state in the next iteration. Error message was: {}" lockException.getMessage());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org