[jira] [Commented] (MSHARED-1) [maven-verifier] Allow handling custom typed artifacts

["Robert Scholte (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048651#comment-17048651 ] 

Robert Scholte commented on MSHARED-1:
--------------------------------------

I have to admit that the code here is weird: the method is asking for the file extension, but inside it is using the dependency type. 
This library has no dependency on Maven, so I think it should be using extensions, not types.
Instead of adding a typeHandler, I'd prefer to switch to extensions.

> [maven-verifier] Allow handling custom typed artifacts
> ------------------------------------------------------
>
>                 Key: MSHARED-1
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-verifier
>    Affects Versions: maven-verifier-1.0
>            Reporter: Arnaud Bailly
>            Priority: Minor
>         Attachments: custom-type.patch
>
>
> In the Verifier class, checking artifacts' presence/absence in the repository does not handle custom types/extensions. The attached patch adds a TypeHandler class (a ligthweight ArtifactHandler) and a addHandler method for managing custom artifact types. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)