[GitHub] [incubator-heron] nlu90 commented on issue #3412: [WIP] migrate to python3 using 2to3 cmd tool

[GitBox <gi...@apache.org>]

nlu90 commented on issue #3412: [WIP] migrate to python3 using 2to3 cmd tool
URL: https://github.com/apache/incubator-heron/pull/3412#issuecomment-561760095
 
 
   > There are a few syntax errors to fix
   
   It seems some syntax error only reported undert python2's syntax checker.
   
   ```# nlu @ tw-mbp-nlu in ~/workspace/heron on git:neng/py3-migration o [9:39:33]
   $ find . -name "*.py" | xargs python -m py_compile
     File "./heron/tools/ui/src/python/main.py", line 190
       print('\n', end='')
                      ^
   SyntaxError: invalid syntax
   
     File "./heron/tools/tracker/src/python/main.py", line 274
       print('\n', end='')
                      ^
   SyntaxError: invalid syntax
   
     File "./heron/tools/cli/src/python/result.py", line 81
       print(msg, file=f)
                      ^
   SyntaxError: invalid syntax
   
     File "./heron/statemgrs/src/python/statemanager.py", line 36
       class StateManager(metaclass=abc.ABCMeta):
                                   ^
   SyntaxError: invalid syntax
   ```
   
   But with python3's syntax checker, those errors are gone.
   ```
   # nlu @ tw-mbp-nlu in ~/workspace/heron on git:neng/py3-migration o [9:39:37] C:1
   $ find . -name "*.py" | xargs python3 -m py_compile
   
   # nlu @ tw-mbp-nlu in ~/workspace/heron on git:neng/py3-migration o [9:40:21]
   $
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services