[GitHub] [hive] zratkai commented on a diff in pull request #4265: HIVE-26982 Fix for Select * from a table containing timestamp column …

["zratkai (via GitHub)" <gi...@apache.org>]

zratkai commented on code in PR #4265:
URL: https://github.com/apache/hive/pull/4265#discussion_r1189562810


##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java:
##########
@@ -2540,6 +2540,8 @@ public static TypeDescription convertTypeInfo(TypeInfo info) {
             return TypeDescription.createDate();
           case TIMESTAMP:
             return TypeDescription.createTimestamp();
+          case TIMESTAMPLOCALTZ:
+            return  TypeDescription.createTimestampInstant();

Review Comment:
   Fixed.



##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/GenericColumnVectorProducer.java:
##########
@@ -220,6 +220,9 @@ public static List<TypeDescription> setTypeBuilderFromSchema(
         case TIMESTAMP:
           type.setKind(OrcProto.Type.Kind.TIMESTAMP);
           break;
+        case TIMESTAMP_INSTANT:
+          type.setKind(Type.Kind.TIMESTAMP_INSTANT);

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org