You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/31 15:45:57 UTC

[GitHub] [arrow] emkornfield commented on a change in pull request #9863: PARQUET-1990: [C++] Refuse to write ConvertedType::NA

emkornfield commented on a change in pull request #9863:
URL: https://github.com/apache/arrow/pull/9863#discussion_r605010964



##########
File path: cpp/src/parquet/thrift_internal.h
##########
@@ -256,6 +256,8 @@ static inline format::Type::type ToThrift(Type::type type) {
 static inline format::ConvertedType::type ToThrift(ConvertedType::type type) {
   // item 0 is NONE
   DCHECK_NE(type, ConvertedType::NONE);
+  // it is forbidden to emit "NA" (PARQUET-1990)
+  DCHECK_NE(type, ConvertedType::NA);

Review comment:
       OK.  I think it prevents accidental writes of UNDEFINED as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org