You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by James Mitchell <jm...@apache.org> on 2005/01/07 19:55:17 UTC
Re: [chain] CopyCommand
I am a committer on Struts and a few Sandbox items, if I had the karma, I
could fix this add a few more tests that demonstrate/validate the fix.
I don't recall if there needs to be a vote.
Martin? Ted? Craig?
--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx
----- Original Message -----
From: "Sean Schofield" <se...@gmail.com>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Friday, January 07, 2005 1:47 PM
Subject: Re: [chain] CopyCommand
> You are correct. Actually, someone reported this bug already a few days
> ago:
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=32894
>
> For those [chain] committers who are listening, I submitted a patch
> for that and its still waiting ;-)
>
> sean
>
>
> On Fri, 7 Jan 2005 13:11:22 -0500, James Mitchell <jm...@apache.org>
> wrote:
>> Just poking around in the source (for my own learning) and came across
>> this
>> bit of code.
>>
>> I won't even pretend to know what this is supposed to do, but unless I'm
>> way
>> off, shouldn't this
>> doing " value = context.get(getFromKey()); " on line 5?
>>
>> 1 public boolean execute(Context context) throws Exception {
>> 2
>> 3 Object value = this.value;
>> 4 if (value == null) {
>> 5 context.get(getFromKey());
>> 6 }
>> 7 if (value != null) {
>> 8 context.put(getToKey(), value);
>> 9 } else {
>> 10 context.remove(getToKey());
>> 11 }
>> 12 return (false);
>> 13
>> 14 }
>> 15
>>
>> --
>> James Mitchell
>> Software Engineer / Open Source Evangelist
>> EdgeTech, Inc.
>> 678.910.8017
>> AIM: jmitchtx
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [chain] CopyCommand
Posted by Sean Schofield <se...@gmail.com>.
> +1 for having you work on commons-chain. Just add yourself to the STATUS file.
Yes the more the merrier!
> Craig
sean
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [chain] CopyCommand
Posted by James Mitchell <jm...@apache.org>.
Cool, I forgot that probably happened when commons-resources got promoted.
--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx
----- Original Message -----
From: "Craig McClanahan" <cr...@gmail.com>
To: "Struts Developers List" <de...@struts.apache.org>
Cc: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Friday, January 07, 2005 2:00 PM
Subject: Re: [chain] CopyCommand
> On Fri, 7 Jan 2005 13:55:17 -0500, James Mitchell <jm...@apache.org>
> wrote:
>> I am a committer on Struts and a few Sandbox items, if I had the karma, I
>> could fix this add a few more tests that demonstrate/validate the fix.
>>
>
> It looks like you already have karma on jakarta-commons.
>
>> I don't recall if there needs to be a vote.
>>
>> Martin? Ted? Craig?
>>
>
> +1 for having you work on commons-chain. Just add yourself to the STATUS
> file.
>
> Craig
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [chain] CopyCommand
Posted by James Mitchell <jm...@apache.org>.
Cool, I forgot that probably happened when commons-resources got promoted.
--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx
----- Original Message -----
From: "Craig McClanahan" <cr...@gmail.com>
To: "Struts Developers List" <de...@struts.apache.org>
Cc: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Friday, January 07, 2005 2:00 PM
Subject: Re: [chain] CopyCommand
> On Fri, 7 Jan 2005 13:55:17 -0500, James Mitchell <jm...@apache.org>
> wrote:
>> I am a committer on Struts and a few Sandbox items, if I had the karma, I
>> could fix this add a few more tests that demonstrate/validate the fix.
>>
>
> It looks like you already have karma on jakarta-commons.
>
>> I don't recall if there needs to be a vote.
>>
>> Martin? Ted? Craig?
>>
>
> +1 for having you work on commons-chain. Just add yourself to the STATUS
> file.
>
> Craig
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [chain] CopyCommand
Posted by Craig McClanahan <cr...@gmail.com>.
On Fri, 7 Jan 2005 13:55:17 -0500, James Mitchell <jm...@apache.org> wrote:
> I am a committer on Struts and a few Sandbox items, if I had the karma, I
> could fix this add a few more tests that demonstrate/validate the fix.
>
It looks like you already have karma on jakarta-commons.
> I don't recall if there needs to be a vote.
>
> Martin? Ted? Craig?
>
+1 for having you work on commons-chain. Just add yourself to the STATUS file.
Craig
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [chain] CopyCommand
Posted by Craig McClanahan <cr...@gmail.com>.
On Fri, 7 Jan 2005 13:55:17 -0500, James Mitchell <jm...@apache.org> wrote:
> I am a committer on Struts and a few Sandbox items, if I had the karma, I
> could fix this add a few more tests that demonstrate/validate the fix.
>
It looks like you already have karma on jakarta-commons.
> I don't recall if there needs to be a vote.
>
> Martin? Ted? Craig?
>
+1 for having you work on commons-chain. Just add yourself to the STATUS file.
Craig
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org