[jira] [Commented] (APEXMALHAR-2492) Correct usage of empty Slice in Malhar Library

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013663#comment-16013663 ] 

ASF GitHub Bot commented on APEXMALHAR-2492:
--------------------------------------------

GitHub user ajaygit158 opened a pull request:

    https://github.com/apache/apex-malhar/pull/621

    APEXMALHAR-2492 Correct usage of empty Slice in Malhar Library

    @vlad There is another piece of code where there is possibility of creating a wrong empty Slice. 
    https://github.com/apache/apex-malhar/blob/master/library/src/test/java/org/apache/apex/malhar/lib/wal/FileSystemWALTest.java#L113
    Should we change the getRandomSlice() implementation if len = 0?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajaygit158/apex-malhar APEXMALHAR-2492

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #621
    
----
commit a850bcf5a5b56cefee997dbae84921662c2e39bc
Author: ajaygit158 <aj...@gmail.com>
Date:   2017-05-17T05:55:33Z

    APEXMALHAR-2492 Correct usage of empty Slice in Malhar Library

----


> Correct usage of empty Slice in Malhar Library
> ----------------------------------------------
>
>                 Key: APEXMALHAR-2492
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2492
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>            Reporter: Ajay Gupta
>            Assignee: Ajay Gupta
>
> In netlet, there are two constructors to create a Slice.
> Slice(byte[] arr) 
> and Slice(byte[] arr, long offset, long length)
> To create an empty slice, we need to pass the byte[] as null. TimeBasedDedupOperator uses byte[0] for the same which needs to be changed.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)