[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation should support...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14103#discussion_r70030535
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala ---
    @@ -41,7 +41,12 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks {
       }
     
       protected def checkEvaluation(
    -      expression: => Expression, expected: Any, inputRow: InternalRow = EmptyRow): Unit = {
    +      originalExpr: => Expression, expected: Any, inputRow: InternalRow = EmptyRow): Unit = {
    +    val expression = originalExpr match {
    +      case replaceable: RuntimeReplaceable => replaceable.replaced
    --- End diff --
    
    > when we add one that uses this it will fail if it doesn't work
    
    Yea, I also checked all the implementations of `RuntimeReplaceable` and they don't have unit test. It will be good if we can test them and verify the `checkEvaluation` can work with `RuntimeReplaceable` after your change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org