You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by UdeniBalasooriya <gi...@git.apache.org> on 2016/08/11 15:39:52 UTC
[GitHub] jmeter pull request #226: Bug 58274 - Removed split methods from JOrphanUtil...
GitHub user UdeniBalasooriya opened a pull request:
https://github.com/apache/jmeter/pull/226
Bug 58274 - Removed split methods from JOrphanUtils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/UdeniBalasooriya/jmeter trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #226
----
commit 1d9f114ef4d6fc80daa3a7269c864b5887675a46
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-07-22T15:36:13Z
Commented split methods.
commit 51fb5d3eb94a233d618842cd5870e8642b27065a
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T15:37:08Z
Removed split methods.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #226: Bug 58274 - Removed split methods from JOrphanUtil...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/226
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #226: Bug 58274 - Removed split methods from JOrphanUtil...
Posted by UdeniBalasooriya <gi...@git.apache.org>.
GitHub user UdeniBalasooriya reopened a pull request:
https://github.com/apache/jmeter/pull/226
Bug 58274 - Removed split methods from JOrphanUtils
Hi,
I would like to contribute to this bug. I removed split methods from JOrphanUtils.java So do I change all the mentioned split methods areas as string.split() or want to make a new methods instead them?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/UdeniBalasooriya/jmeter trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #226
----
commit 1d9f114ef4d6fc80daa3a7269c864b5887675a46
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-07-22T15:36:13Z
Commented split methods.
commit 51fb5d3eb94a233d618842cd5870e8642b27065a
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T15:37:08Z
Removed split methods.
commit 89d45a36b754e152fd9fdbb27845361734a0ffa8
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T16:23:30Z
Modified Data.java file
commit f646e4423446dfd7d27f2102e21ac984d1544295
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T16:34:33Z
Used string.split() in split method .
commit cea26776d9bcd7977253341605e947d547ae5a54
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T16:58:09Z
changed file.
commit 26b22ffdef4279422215dee64ff00e83a6a13c10
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T17:11:06Z
Changed JOrphanUtils.java file.
commit e5fd76918781953bdf09342160fef23d06250495
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T17:17:30Z
Modified JOrphanUtils.java file.
commit 60b6044203fbb05296c5b532d2c261306451f03b
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T17:52:31Z
Modified JOrphanUtils.java file.
commit 81e81b23ba601033e7719f6e912f5d5da67916fd
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T19:14:28Z
Modified JOrphanUtils.java file.
commit 5cee9732d590bb86cadf7d518bc298d1080c5cac
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-11T19:25:05Z
Modified JOrphanUtils.java file.
commit 2d7ad10358ae93c686a48708fcd7aec5e7591b67
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T05:58:26Z
changed file.
commit b5d10b49d3edac4dd4c1c6ec5f4cc648eb841b7c
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T06:17:06Z
changed file.
commit c66aeb2dfcb5bf8a72407e7b01507cb0e553d042
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T06:31:05Z
changed file.
commit 3801817a62defe4c4f44ade3ebc353e23f2df2f0
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T06:47:23Z
changed file.
commit 2a8323338f6b285716d5bea180bf1b099a94c481
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T07:05:31Z
changed JMeter.java file.
commit 22d53ae313cf2cd36b011c833bf21b9d6f469abc
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T07:23:58Z
Changed TestPlan.java
commit 1dbd3934100951aa4f9c1851c542714befc08599
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T07:27:06Z
changed JMeterMenuBar.java
commit 5ccaa0a6c368ab095b19179b7bf28e394ca703a1
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T07:33:37Z
changed BSFTestElement.java
commit a994b498fc81132a9be317148ec2ba2638fbc9a6
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T07:35:30Z
changed BeanShellTestElement.java
commit 9ceb4fb5202b319e1aad685a7dc1b23843253861
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T07:37:06Z
changed JMeterUtils.java
commit c9ec47143892f4b54e79ce992ef5ac657c701b38
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T07:38:33Z
changed JSR223TestElement.java
commit 1161a6413243fea50bf57d8c028652d2fc402c4b
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T07:39:42Z
changed TestBeanGUI.java
commit c0c34712132c646e275232da306b7ee32475bd48
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T07:46:44Z
changed MenuFactory.java
commit 897ed10dfb0ec2ac0726203398d3dd005b306883
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T08:14:03Z
changed CSVDataSet.java
commit 19931df7efcf0bd2001a9d3725998dff950d2f78
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T08:41:59Z
changed CSVDataSet.java
commit e30ab70351c6b8e628ea0504902999d3362ed17b
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T09:32:56Z
changed SplitFunction.java
commit 6cd22e4ba91b342acc4daa17e73f122c26262e13
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T09:41:04Z
changed MultipartUrlConfig.java
commit 5ebdc64b482c0337a781825683d4872372c051d5
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T09:42:39Z
changed Headermanager.java
commit 55ecacf6408cc0f0c735081140ca36f2f484c255
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T09:44:47Z
changed HTTPSamplerBase.java
commit 8cf50d89d8e805f9fc507e347e477a9eb80e00b6
Author: Udeni Balasooriya <e1...@ce.pdn.ac.lk>
Date: 2016-08-28T09:51:23Z
changed HTTPSamplerBase.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #226: Bug 58274 - Removed split methods from JOrphanUtils
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/226
Hello,
Thanks for your work but next time please ask on jmeter dev mailing list before working on a PR.
We cannot integrate this PR as it is now in conflict and would need too much work to be integrated.
Integrating PR that touch a lot of code without JUNIT non regression testing is too risky.
Regards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #226: Bug 58274 - Removed split methods from JOrphanUtil...
Posted by UdeniBalasooriya <gi...@git.apache.org>.
Github user UdeniBalasooriya closed the pull request at:
https://github.com/apache/jmeter/pull/226
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---