You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2021/07/06 05:45:22 UTC
[GitHub] [incubator-brpc] serverglen opened a new pull request #1461: Implement brpc server Start(PortRange, const ServerOptions*)
serverglen opened a new pull request #1461:
URL: https://github.com/apache/incubator-brpc/pull/1461
Related issue：#1460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on a change in pull request #1461: Implement brpc server Start(PortRange, const ServerOptions*)
Posted by GitBox <gi...@apache.org>.
serverglen commented on a change in pull request #1461:
URL: https://github.com/apache/incubator-brpc/pull/1461#discussion_r664993772
##########
File path: src/brpc/server.h
##########
@@ -389,6 +389,8 @@ class Server {
int Start(int port, const ServerOptions* opt);
// Start on `ip_str' + any useable port in `range'
int Start(const char* ip_str, PortRange range, const ServerOptions *opt);
+ // Start on IP_ANT + first useable port in `range'
Review comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on pull request #1461: Implement brpc server Start(PortRange, const ServerOptions*)
Posted by GitBox <gi...@apache.org>.
serverglen commented on pull request #1461:
URL: https://github.com/apache/incubator-brpc/pull/1461#issuecomment-909931918
@zyearn @lorinlee @cdjingit @TousakaRin 辛苦帮review下呗，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm merged pull request #1461: Implement brpc server Start(PortRange, const ServerOptions*)
Posted by GitBox <gi...@apache.org>.
wwbmmm merged pull request #1461:
URL: https://github.com/apache/incubator-brpc/pull/1461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] lorinlee commented on a change in pull request #1461: Implement brpc server Start(PortRange, const ServerOptions*)
Posted by GitBox <gi...@apache.org>.
lorinlee commented on a change in pull request #1461:
URL: https://github.com/apache/incubator-brpc/pull/1461#discussion_r664545743
##########
File path: src/brpc/server.h
##########
@@ -389,6 +389,8 @@ class Server {
int Start(int port, const ServerOptions* opt);
// Start on `ip_str' + any useable port in `range'
int Start(const char* ip_str, PortRange range, const ServerOptions *opt);
+ // Start on IP_ANT + first useable port in `range'
Review comment:
typo IP_ANY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on pull request #1461: Implement brpc server Start(PortRange, const ServerOptions*)
Posted by GitBox <gi...@apache.org>.
serverglen commented on pull request #1461:
URL: https://github.com/apache/incubator-brpc/pull/1461#issuecomment-909931918
@zyearn @lorinlee @cdjingit @TousakaRin 辛苦帮review下呗，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org