You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/03 14:47:34 UTC
[GitHub] [tvm] tqchen commented on a change in pull request #7572: [Vulkan] Support passing 64 bit scalar
tqchen commented on a change in pull request #7572:
URL: https://github.com/apache/tvm/pull/7572#discussion_r586477695
##########
File path: src/runtime/pack_args.h
##########
@@ -40,13 +40,24 @@ namespace tvm {
namespace runtime {
/*!
* \brief argument union type of 32bit.
- * Choose 32 bit because most GPU API do not work well with 64 bit.
*/
union ArgUnion {
Review comment:
Let us rename to ArgUnion32 to avoid confusion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org