You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kp...@apache.org on 2013/11/08 16:28:43 UTC
svn commit: r1540077 - in /tomcat/trunk/webapps/examples/jsp/jsp2/jspx:
svgexample.html textRotate.html textRotate.jspx
Author: kpreisser
Date: Fri Nov 8 15:28:42 2013
New Revision: 1540077
URL: http://svn.apache.org/r1540077
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55383
Improve HTML markup in the examples.
Modified:
tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html
tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.html
tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.jspx
Modified: tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html?rev=1540077&r1=1540076&r2=1540077&view=diff
==============================================================================
--- tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html (original)
+++ tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html Fri Nov 8 15:28:42 2013
@@ -1,4 +1,4 @@
-<!--
+<!DOCTYPE html><!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
@@ -16,11 +16,11 @@
-->
<html>
<head>
+ <meta charset="UTF-8">
<title>JSP 2.0 SVG Example</title>
</head>
<body>
<h1>JSP 2.0 SVG Example</h1>
- <hr>
This example uses JSP 2.0's new, simplified JSPX syntax to render a
Scalable Vector Graphics (SVG) document. When you view the source,
notice the lack of a <jsp:root> element! The text to be rendered
@@ -42,11 +42,9 @@
<li>Paste the URL into Batik's Location field and press Enter</li>
<li>Customize by changing the name=JSPX parameter</li>
</ol>
- <br>
+ <p style="margin-top: 2em;">
The following is a screenshot of the resulting image, for those that
- don't have an SVG viewer:
- <blockquote>
- <img src="textRotate.jpg" border="1">
- </blockquote>
+ don't have an SVG viewer:<br>
+ <img src="textRotate.jpg" alt="[Screenshot image]" style="border: 1px solid #000;">
</body>
</html>
Modified: tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.html
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.html?rev=1540077&r1=1540076&r2=1540077&view=diff
==============================================================================
--- tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.html (original)
+++ tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.html Fri Nov 8 15:28:42 2013
@@ -1,4 +1,4 @@
-<html>
+<!DOCTYPE html>
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
@@ -15,18 +15,18 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
+<html lang="en">
<head>
+<meta charset="UTF-8">
<title>View Source Code</title>
-<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
-<body bgcolor="#FFFFFF">
-<p><font color="#0000FF"><a href="textRotate.jspx"><img src="../../images/execute.gif" align="right" border="0"></a><a
-href="../../index.html"><img src="../../images/return.gif" width="24" height="24" align="right" border="0"></a></font></p>
+<body>
+<p><a href="textRotate.jspx"><img src="../../images/execute.gif" alt="Execute" style="border: 0;"></a> <a
+href="../../index.html"><img src="../../images/return.gif" alt="Return" style="border: 0;"></a></p>
<h3><a href="textRotate.jspx.html">Source Code for SVG (Scalable Vector Graphics)
-Example<font color="#0000FF"></a>
- </font> </h3>
+Example</a></h3>
</body>
</html>
Modified: tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.jspx
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.jspx?rev=1540077&r1=1540076&r2=1540077&view=diff
==============================================================================
--- tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.jspx (original)
+++ tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.jspx Fri Nov 8 15:28:42 2013
@@ -1,3 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
RE: svn commit: r1540077 - in /tomcat/trunk/webapps/examples/jsp/jsp2/jspx: svgexample.html textRotate.html textRotate.jspx
Posted by Konstantin Preißer <kp...@apache.org>.
Hi Konstantin,
> -----Original Message-----
> From: Konstantin Kolinko [mailto:knst.kolinko@gmail.com]
> Sent: Saturday, November 9, 2013 6:24 AM
> To: Tomcat Developers List
> Subject: Re: svn commit: r1540077 - in
> /tomcat/trunk/webapps/examples/jsp/jsp2/jspx: svgexample.html
> textRotate.html textRotate.jspx
>
> 2013/11/8 <kp...@apache.org>:
> > Author: kpreisser
> > Date: Fri Nov 8 15:28:42 2013
> > New Revision: 1540077
> >
> > URL: http://svn.apache.org/r1540077
> > Log:
> > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55383
> > Improve HTML markup in the examples.
> >
> > Modified:
> > tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html
> > tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.html
> > tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.jspx
> >
> > Modified:
> tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html
> > URL:
> http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/jsp/jsp2/js
> px/svgexample.html?rev=1540077&r1=1540076&r2=1540077&view=diff
> >
> ==========================================================
> ====================
> > --- tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html
> (original)
> > +++ tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html Fri
> Nov 8 15:28:42 2013
> > @@ -1,4 +1,4 @@
> > -<!--
> > +<!DOCTYPE html><!--
> > Licensed to the Apache Software Foundation (ASF) under one or more
> > contributor license agreements. See the NOTICE file distributed with
> > this work for additional information regarding copyright ownership.
> > @@ -16,11 +16,11 @@
> > -->
> > <html>
> > <head>
> > + <meta charset="UTF-8">
>
> This *.html file is served with Content-Type of text/html.
>
> To really serve it with "text/html; charset=UTF-8" the recommended way
> is to configure a
> AddDefaultCharsetFilter
> http://tomcat.apache.org/tomcat-8.0-
> doc/config/filter.html#Add_Default_Character_Set_Filter
Thanks.
However, for static *.html files I don't see a need to add a charset=UTF-8 value to the Content-Type header, as the browser will get the encoding from the <meta> tag.
Regards,
Konstantin Preißer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1540077 - in /tomcat/trunk/webapps/examples/jsp/jsp2/jspx:
svgexample.html textRotate.html textRotate.jspx
Posted by Konstantin Kolinko <kn...@gmail.com>.
2013/11/8 <kp...@apache.org>:
> Author: kpreisser
> Date: Fri Nov 8 15:28:42 2013
> New Revision: 1540077
>
> URL: http://svn.apache.org/r1540077
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55383
> Improve HTML markup in the examples.
>
> Modified:
> tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html
> tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.html
> tomcat/trunk/webapps/examples/jsp/jsp2/jspx/textRotate.jspx
>
> Modified: tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html
> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html?rev=1540077&r1=1540076&r2=1540077&view=diff
> ==============================================================================
> --- tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html (original)
> +++ tomcat/trunk/webapps/examples/jsp/jsp2/jspx/svgexample.html Fri Nov 8 15:28:42 2013
> @@ -1,4 +1,4 @@
> -<!--
> +<!DOCTYPE html><!--
> Licensed to the Apache Software Foundation (ASF) under one or more
> contributor license agreements. See the NOTICE file distributed with
> this work for additional information regarding copyright ownership.
> @@ -16,11 +16,11 @@
> -->
> <html>
> <head>
> + <meta charset="UTF-8">
This *.html file is served with Content-Type of text/html.
To really serve it with "text/html; charset=UTF-8" the recommended way
is to configure a
AddDefaultCharsetFilter
http://tomcat.apache.org/tomcat-8.0-doc/config/filter.html#Add_Default_Character_Set_Filter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org