You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/08/12 14:01:09 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

GitHub user pritisarap12 opened a pull request:

    https://github.com/apache/cloudstack/pull/684

    CLOUDSTACK-8728: Testcase to Verify if VRs IP 

    Testcase to check if VR's IP changes if it is destroyed and re-created in basic zone.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-8728-Testcase-to-Verify-if-VRs-IP-changes-if-it-is-destroyed-and-re-created-in-Basic-Zone

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/684.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #684
    
----
commit ea0d5ca141c3b73f212be37953b96b823b179600
Author: Priti Sarap <pr...@clogeny.com>
Date:   2015-08-12T11:58:04Z

    CLOUDSTACK:8728-Testcase to Verify if VRs IP changes if it is destroyed and re created in Basic Zone

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/684#discussion_r37972977
  
    --- Diff: test/integration/smoke/test_routers.py ---
    @@ -796,3 +830,122 @@ def test_09_reboot_router(self):
                 "Router response after reboot is either is invalid\
                         or in stopped state")
             return
    +
    +    def check_virtual_machine_accessibility(self, virtual_machine):
    +        response = virtual_machine.getState(
    +            self.userapiclient,
    +            VirtualMachine.RUNNING
    +        )
    +        self.assertEqual(response[0], PASS, "Virtual machine is not running")
    +
    +        # Check VM Accessibility
    +        try:
    +            SshClient(host=virtual_machine.ssh_ip,
    +                      port=self.services['natrule']['publicport'],
    +                      user=virtual_machine.username,
    +                      passwd=virtual_machine.password)
    +        except Exception as e:
    +            raise Exception("Error while trying SSH to VM: %s" % e)
    +
    +    def try_ssh_to_host(self):
    +        list_virtual_machine_response = list_virtual_machines(
    +            self.apiclient,
    +            listall=True)
    +        status = validateList(list_virtual_machine_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "VM List Validation Failed due to %s" %
    +            status[2])
    +
    +        host_id = list_virtual_machine_response[0].hostid
    +        list_host_response = list_hosts(self.apiclient, id=host_id)
    +        status = validateList(list_host_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "Host List Validation Failed due to %s" %
    +            status[2])
    +
    +        self.services['hosts'][self.hypervisor.lower()]['password'] = "xenroot"
    --- End diff --
    
    Can you please remove the hardcoded password for the host and see if you can get from the config file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-134919215
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-147172068
  
    @pritisarap12 Please squash the commits, as there are now 2 merge commits and I cannot proceed like this. Make sure it has a single commit. Ping me if you need help with this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-143590546
  
    @pritisarap12 Any update on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-137535485
  
    @miguelaferreira OK, check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/684


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-130273467
  
    Testcase result:
    
    Check if Virtual Router has same IP after network restart or not. ... === TestName: test_01_vr_has_same_ip | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 245.730s
    
    OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/684#discussion_r37973474
  
    --- Diff: test/integration/smoke/test_routers.py ---
    @@ -796,3 +830,122 @@ def test_09_reboot_router(self):
                 "Router response after reboot is either is invalid\
                         or in stopped state")
             return
    +
    +    def check_virtual_machine_accessibility(self, virtual_machine):
    +        response = virtual_machine.getState(
    +            self.userapiclient,
    +            VirtualMachine.RUNNING
    +        )
    +        self.assertEqual(response[0], PASS, "Virtual machine is not running")
    +
    +        # Check VM Accessibility
    +        try:
    +            SshClient(host=virtual_machine.ssh_ip,
    +                      port=self.services['natrule']['publicport'],
    +                      user=virtual_machine.username,
    +                      passwd=virtual_machine.password)
    +        except Exception as e:
    +            raise Exception("Error while trying SSH to VM: %s" % e)
    +
    +    def try_ssh_to_host(self):
    +        list_virtual_machine_response = list_virtual_machines(
    +            self.apiclient,
    +            listall=True)
    +        status = validateList(list_virtual_machine_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "VM List Validation Failed due to %s" %
    +            status[2])
    +
    +        host_id = list_virtual_machine_response[0].hostid
    +        list_host_response = list_hosts(self.apiclient, id=host_id)
    +        status = validateList(list_host_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "Host List Validation Failed due to %s" %
    +            status[2])
    +
    +        self.services['hosts'][self.hypervisor.lower()]['password'] = "xenroot"
    +        ssh_object = SshClient(
    +            host=list_host_response[0].ipaddress,
    +            port=self.services['natrule']['publicport'],
    +            user=self.services['hosts'][self.hypervisor.lower()]['username'],
    +            passwd=self.services['hosts'][self.hypervisor.lower()]['password']
    +        )
    +        hostname_from_host = ssh_object.execute("uname -n")
    +        ssh_object.execute("ssh-keygen -R %s" % hostname_from_host[0])
    +        ssh_object.execute("exit")
    +        return ssh_object
    +
    +    def get_inet_address(self, ssh_object):
    +        list_ssvm_response = list_ssvms(
    +            self.apiclient,
    +            systemvmtype='secondarystoragevm'
    +        )
    +        status = validateList(list_ssvm_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "SSVM List Validation Failed due to %s" %
    +            status[2])
    +
    +        command = "ssh  -o StrictHostKeyChecking=no -i /root/.ssh/id_rsa.cloud %s -p 3922 'ifconfig eth0'" \
    +            % list_ssvm_response[0].linklocalip
    +        ssh_response = ssh_object.execute(command)
    --- End diff --
    
    What are we trying to get here? linklocalip and "ifconfig eth0" would be same on SSVM. You may have to check this for Router VM. Please modify this method implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/684#discussion_r37973579
  
    --- Diff: test/integration/smoke/test_routers.py ---
    @@ -796,3 +830,122 @@ def test_09_reboot_router(self):
                 "Router response after reboot is either is invalid\
                         or in stopped state")
             return
    +
    +    def check_virtual_machine_accessibility(self, virtual_machine):
    +        response = virtual_machine.getState(
    +            self.userapiclient,
    +            VirtualMachine.RUNNING
    +        )
    +        self.assertEqual(response[0], PASS, "Virtual machine is not running")
    +
    +        # Check VM Accessibility
    +        try:
    +            SshClient(host=virtual_machine.ssh_ip,
    +                      port=self.services['natrule']['publicport'],
    +                      user=virtual_machine.username,
    +                      passwd=virtual_machine.password)
    +        except Exception as e:
    +            raise Exception("Error while trying SSH to VM: %s" % e)
    +
    +    def try_ssh_to_host(self):
    +        list_virtual_machine_response = list_virtual_machines(
    +            self.apiclient,
    +            listall=True)
    +        status = validateList(list_virtual_machine_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "VM List Validation Failed due to %s" %
    +            status[2])
    +
    +        host_id = list_virtual_machine_response[0].hostid
    +        list_host_response = list_hosts(self.apiclient, id=host_id)
    +        status = validateList(list_host_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "Host List Validation Failed due to %s" %
    +            status[2])
    +
    +        self.services['hosts'][self.hypervisor.lower()]['password'] = "xenroot"
    +        ssh_object = SshClient(
    +            host=list_host_response[0].ipaddress,
    +            port=self.services['natrule']['publicport'],
    +            user=self.services['hosts'][self.hypervisor.lower()]['username'],
    +            passwd=self.services['hosts'][self.hypervisor.lower()]['password']
    +        )
    +        hostname_from_host = ssh_object.execute("uname -n")
    +        ssh_object.execute("ssh-keygen -R %s" % hostname_from_host[0])
    +        ssh_object.execute("exit")
    +        return ssh_object
    --- End diff --
    
    What is the guarantee that  RouterVM and Guest vm will be on the same host? We have to the host id of the VR and  get the ssh object for that host.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/684#discussion_r37973271
  
    --- Diff: test/integration/smoke/test_routers.py ---
    @@ -796,3 +830,122 @@ def test_09_reboot_router(self):
                 "Router response after reboot is either is invalid\
                         or in stopped state")
             return
    +
    +    def check_virtual_machine_accessibility(self, virtual_machine):
    +        response = virtual_machine.getState(
    +            self.userapiclient,
    +            VirtualMachine.RUNNING
    +        )
    +        self.assertEqual(response[0], PASS, "Virtual machine is not running")
    +
    +        # Check VM Accessibility
    +        try:
    +            SshClient(host=virtual_machine.ssh_ip,
    +                      port=self.services['natrule']['publicport'],
    +                      user=virtual_machine.username,
    +                      passwd=virtual_machine.password)
    +        except Exception as e:
    +            raise Exception("Error while trying SSH to VM: %s" % e)
    +
    +    def try_ssh_to_host(self):
    +        list_virtual_machine_response = list_virtual_machines(
    +            self.apiclient,
    +            listall=True)
    +        status = validateList(list_virtual_machine_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "VM List Validation Failed due to %s" %
    +            status[2])
    +
    +        host_id = list_virtual_machine_response[0].hostid
    +        list_host_response = list_hosts(self.apiclient, id=host_id)
    +        status = validateList(list_host_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "Host List Validation Failed due to %s" %
    +            status[2])
    +
    +        self.services['hosts'][self.hypervisor.lower()]['password'] = "xenroot"
    +        ssh_object = SshClient(
    +            host=list_host_response[0].ipaddress,
    +            port=self.services['natrule']['publicport'],
    +            user=self.services['hosts'][self.hypervisor.lower()]['username'],
    +            passwd=self.services['hosts'][self.hypervisor.lower()]['password']
    +        )
    +        hostname_from_host = ssh_object.execute("uname -n")
    +        ssh_object.execute("ssh-keygen -R %s" % hostname_from_host[0])
    +        ssh_object.execute("exit")
    +        return ssh_object
    +
    +    def get_inet_address(self, ssh_object):
    +        list_ssvm_response = list_ssvms(
    +            self.apiclient,
    +            systemvmtype='secondarystoragevm'
    +        )
    +        status = validateList(list_ssvm_response)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "SSVM List Validation Failed due to %s" %
    +            status[2])
    +
    +        command = "ssh  -o StrictHostKeyChecking=no -i /root/.ssh/id_rsa.cloud %s -p 3922 'ifconfig eth0'" \
    +            % list_ssvm_response[0].linklocalip
    +        ssh_response = ssh_object.execute(command)
    +        return ssh_response[1]
    +
    +    @attr(tags=['basic'], required_hardware="true")
    +    def test_10_vr_has_same_ip(self):
    +        """ Check if Virtual Router has same IP after network restart or not.
    +            1. Deploy VM and check it's accessibility
    +            2. Try SSH to host
    +            3. Get link local IP and inet address of SSVM
    +            4. Restart network with cleanup option true
    +            5. Deploy another VM and check it's Inet address
    +        """
    +
    +        # Step 1: Deploy VM and check it's accessibility
    +        self.check_virtual_machine_accessibility(self.vm_1)
    +
    +        # Step 2: Try SSH to host
    +        ssh_object = self.try_ssh_to_host()
    +
    +        # Step 3: Get local IP and inet address of SSVM
    +        inet_address_before_restart = self.get_inet_address(ssh_object)
    +
    +        # Step 4: Restart network with cleanup option true
    +        network_details = list_networks(
    +            self.apiclient,
    +            account=self.account.name
    +        )
    +        status = validateList(network_details)
    +        self.assertEqual(
    +            status[0],
    +            PASS,
    +            "Network List Validation Failed due to %s" %
    +            status[2])
    +
    +        cmd = restartNetwork.restartNetworkCmd()
    +        cmd.id = network_details[0].id
    +        cmd.cleanup = True
    +        self.apiclient.restartNetwork(cmd)
    +
    +        # Step 5: Deploy another VM and check it's inet address
    +        vm_2 = VirtualMachine.create(
    +            self.apiclient,
    +            self.services["virtual_machine"],
    +            templateid=self.template.id,
    +            accountid=self.account.name,
    +            domainid=self.account.domainid,
    +            serviceofferingid=self.service_offering.id,
    +            zoneid=self.zone.id,
    +            mode=self.zone.networktype
    +        )
    +        self.check_virtual_machine_accessibility(vm_2)
    +        ssh_object = self.try_ssh_to_host()
    +        inet_address_after_restart = self.get_inet_address(ssh_object)
    --- End diff --
    
    After network restart we are suppose to verify the VR's IP address not the SSVM ip address. Can you please double check this test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-134488914
  
    Merged the testcase in test_routers.py file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-137394628
  
    @remibergsma `rebase -i` and deleting the line of the merge commit will get you what you want. I see that squashing would too, but then the problem is in the generalisation that tends to happen in the next PR someone makes. People might thing, let me squash everything before someone asks me to do it ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-135945903
  
    @miguelaferreira If I recall correctly, `rebase -i` (where you'd usually squash stuff together and such) and doing nothing, will remove the merge commit already. It's better to say to rebase I guess ;-) End goal is indeed to keep only the first commit. Cc @pritisarap12 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-148614442
  
    @remibergsma:  I force pushed the commit and it is showing green signal now you can run the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-182751801
  
    LGTM !!
    
    Test router internal basic zone ... SKIP: Marvin configuration has no host credentials to                            check router services
    Test router internal advanced zone ... SKIP: Marvin configuration has no host credentials                            to check router services
    Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS ===
    ok
    Test restart network without cleanup ... SKIP: Marvin configuration has no host credentials                            to check router services
    Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS ===
    ok
    Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS ===
    ok
    Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
    ok
    Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
    ok
    Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 9 tests in 287.782s
    
    OK (SKIP=3)
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-135792733
  
    Something strange with this PR. The second commit merges master into the PR
    
    Was this an attempt to bring in new changes from master? If that was the case, then a rebase would have been the better option.
    
    @pritisarap12 can you please remove the merge commit, and rebase instead?
    Let me know if you would like me to help you with that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-135887682
  
    @pritisarap12 Please squash the commits (get rid of the merge commit). We cannot merge it like this. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-148344368
  
    @prits09 Thanks! It seems Jenkins failed and I don't think it's you. Please force-push the commit again so the rests will re-run. After that, I'll run the test myself. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-135894663
  
    @remi: do you mean squash to get rid of the merge commit? Wouldn't the resulting commit have 2 parents? If so, that's not the solution.
    
    Or do you mean squash all but the merge commit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-134489114
  
    Testcase result:
    
    Check if Virtual Router has same IP after network restart or not. ... === TestName: test_10_vr_has_same_ip | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 294.769s
    
    OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by prits09 <gi...@git.apache.org>.
Github user prits09 commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-147308519
  
    squashed the commits into single commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:

    https://github.com/apache/cloudstack/pull/684#issuecomment-144003970
  
    Merged the testcase in the existing testcase test_03_restart_network_cleanup by adding support for basic setup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---