[GitHub] [calcite] walterddr commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION
URL: https://github.com/apache/calcite/pull/1011#discussion_r264447348
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java
 ##########
 @@ -7385,6 +7387,24 @@ public void subTestIntervalSecondFailsValidation() {
         "(?s).*Encountered \"from\" at .*");
   }
 
+  /**
+   * Tests that applying member function of a specific type as a suffix function
+   */
+  @Test public void testMemberFunction() {
+    check("SELECT myColumn.func(a, b) FROM tbl",
 
 Review comment:
   Yes, this is something I wasn't absolutely sure. Generally speaking member function should come after a record type. However, during parsing time there's really no way to distinguish. 
   
   [CALCITE-2906](https://issues.apache.org/jira/browse/CALCITE-2906) is more broader discussion on this (not just member function, but also affects DOT operator after array element, expression, etc.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services