You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2023/06/28 12:37:41 UTC
[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #293: Fix retriable errors not handled well when creating producer or consumer
BewareMyPower commented on code in PR #293:
URL: https://github.com/apache/pulsar-client-cpp/pull/293#discussion_r1245145161
##########
lib/ConsumerImpl.cc:
##########
@@ -318,10 +318,13 @@ void ConsumerImpl::handleCreateConsumer(const ClientConnectionPtr& cnx, Result r
scheduleReconnection(get_shared_this_ptr());
} else {
// Consumer was not yet created, retry to connect to broker if it's possible
- if (isRetriableError(result) && (creationTimestamp_ + operationTimeut_ < TimeUtils::now())) {
Review Comment:
Fixed, PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org