You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aalexandrov <gi...@git.apache.org> on 2015/10/16 00:24:13 UTC
[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/1260
[docs] Fix documentation for building Flink with Scala 2.11 or 2.10
This fixes some dead anchor links and aligns the text in "Build Flink for a specific Scala version" against the commands required by the current master.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aalexandrov/flink doc-scalabuild-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1260
----
commit fd86d72394b4dedaf6724398b041655825f0c7d4
Author: Alexander Alexandrov <al...@gmail.com>
Date: 2015-10-15T22:21:23Z
[docs] Fix documentation for building Flink with Scala 2.11 or 2.10
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...
Posted by aalexandrov <gi...@git.apache.org>.
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1260#issuecomment-149847793
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1260#issuecomment-149623979
+1 looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1260#issuecomment-149861741
I agree, it makes sense to add the documentation as a separate PR. I think here in the office, all of us are using IntelliJ by now. But I could try to get my old Eclipse setup going again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...
Posted by aalexandrov <gi...@git.apache.org>.
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1260#issuecomment-149848186
@tillrohrmann The list of TODOs from the JIRA issue is referring concretely to IntelliJ. Is there some Eclipse user who can see what the corresponding actions for Eclipse would be after I make a PR for that.
Also, I think that this belongs to a part of the documentation related to development.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1260#issuecomment-149838480
Will merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs] Fix documentation for building Flink wi...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1260#issuecomment-149567354
Looks good to me. +1 for merging. Maybe we could also add some documentation for how to change the Scala version with your favourite IDE as described by you in https://issues.apache.org/jira/browse/FLINK-2858.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---