[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5146: arch/arm/samv7: rework SAMv7 timer counter implementation

[GitBox <gi...@apache.org>]

acassis commented on a change in pull request #5146:
URL: https://github.com/apache/incubator-nuttx/pull/5146#discussion_r777522118



##########
File path: arch/arm/src/samv7/sam_freerun.c
##########
@@ -220,8 +220,8 @@ int sam_freerun_initialize(struct sam_freerun_s *freerun, int chan,
 int sam_freerun_counter(struct sam_freerun_s *freerun, struct timespec *ts)
 {
   uint64_t usec;
-  uint32_t counter;
-  uint32_t verify;
+  uint16_t counter;

Review comment:
       @pkarashchenko since you are changing "counter" and "verify" to uint16_t I suggest you to move down after the uint32_t variables. It is not a requirement, but a good practice to avoid alignment issues.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org