You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2013/12/27 03:36:34 UTC
Review Request 16480: Refactoring patch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16480/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-6095
https://issues.apache.org/jira/browse/HIVE-6095
Repository: hive
Description
-------
Refactoring patch, to use Paths instead of Strings.
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/MergeWork.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/RCFileMergeMapper.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java 1553614
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadMultiFilesDesc.java 1553614
trunk/ql/src/test/results/compiler/plan/case_sensitivity.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/input1.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/input2.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/input3.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/input6.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/input7.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/input9.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/input_testsequencefile.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/sample2.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/sample3.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/sample4.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/sample5.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/sample6.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/sample7.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/subq.q.xml 1553614
trunk/ql/src/test/results/compiler/plan/union.q.xml 1553614
Diff: https://reviews.apache.org/r/16480/diff/
Testing
-------
Refactoring patch. Existing regression suite suffices.
Thanks,
Ashutosh Chauhan
Re: Review Request 16480: Refactoring patch
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16480/#review30897
-----------------------------------------------------------
Ship it!
Ship It!
- Xuefu Zhang
On Dec. 27, 2013, 2:36 a.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16480/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2013, 2:36 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6095
> https://issues.apache.org/jira/browse/HIVE-6095
>
>
> Repository: hive
>
>
> Description
> -------
>
> Refactoring patch, to use Paths instead of Strings.
>
>
> Diffs
> -----
>
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/MergeWork.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/RCFileMergeMapper.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java 1553614
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadMultiFilesDesc.java 1553614
> trunk/ql/src/test/results/compiler/plan/case_sensitivity.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/input1.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/input2.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/input3.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/input6.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/input7.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/input9.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/input_testsequencefile.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/sample2.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/sample3.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/sample4.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/sample5.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/sample6.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/sample7.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/subq.q.xml 1553614
> trunk/ql/src/test/results/compiler/plan/union.q.xml 1553614
>
> Diff: https://reviews.apache.org/r/16480/diff/
>
>
> Testing
> -------
>
> Refactoring patch. Existing regression suite suffices.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>