You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/05/03 00:07:51 UTC
[PR] Re-apply code-block CSS to guides/resources/css/guide.css (PR #482 follow-up) [grails-static-website]
jamesfredley opened a new pull request, #484:
URL: https://github.com/apache/grails-static-website/pull/484
## Summary
Follow-up to #482, which targeted the wrong file and so had no effect on the live guides site.
### What went wrong in #482
#482 added five code-block CSS rule blocks (inline `<code>` pill, always-visible language chip, `.listingblock > .title` gray header bar, square top corners on titled listings, horizontal overflow) to `buildSrc/src/main/template/css/main.css`.
That file is the source for `guides/resources/css/main.css`, and the legacy `buildSrc/src/main/template/style/{layout,guideItem,referenceItem}.html` templates do link `\/css/main.css` - but **those legacy templates are not used by the modern `RenderGuidesPlugin` pipeline**. The actual rendered guide pages link only:
```html
<link rel='stylesheet' href='https://grails.apache.org/stylesheets/screen.css'/>
<link rel='stylesheet' href='https://grails.apache.org/stylesheets/plugin.css'/>
<link rel='stylesheet' href='../css/guide.css'/>
```
(verified by fetching https://grails.apache.org/guides/grails-fields-custom-widgets-and-wrappers/8/guide/index.html). `main.css` is never requested.
So #482's CSS additions, while merged, are dead code on the guides site.
### Fix
Re-apply the same five rule blocks to `guides/resources/css/guide.css` - the file the rendered guide pages actually load.
#482's additions to `main.css` are left in place: they're harmless if unused, and they keep the legacy templates consistent in case they ever get re-enabled.
## Verification
```bash
./gradlew renderGuide_grails_fields_custom_widgets_and_wrappers_8 --rerun-tasks --no-configuration-cache
```
Confirms:
- `p > code` selector present in `build/dist/guides/grails-fields-custom-widgets-and-wrappers/8/css/guide.css` (1 occurrence)
- `.listingblock > .title` selectors present (3 occurrences across the rule blocks)
- Built `guide.css` size: 5867 -> 8432 bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Re-apply code-block CSS to guides/resources/css/guide.css (PR #482 follow-up) [grails-static-website]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #484:
URL: https://github.com/apache/grails-static-website/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org