You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/21 23:49:38 UTC

[GitHub] [incubator-mxnet] ptrendx opened a new pull request #18768: Fix crash when accessing already destructed static variables

ptrendx opened a new pull request #18768:
URL: https://github.com/apache/incubator-mxnet/pull/18768


   ## Description ##
   Fixes #18765
   When the script terminates, the threads in the engine are still free to execute ops. If those ops use `static` variables they may already be destroyed by the time a thread tries to access them, which causes a segfault.
   
   Previously there was a little bit of protection against it by setting `shutdown_phase_` in the engine and not executing new ops when it was set. However, if the op takes a long time, it is possible for it to already be inside the op, therefore still triggering the segfault. 
   
   @leezu @eric-haibin-lin @szha 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #18768: Fix crash when accessing already destructed static variables

Posted by GitBox <gi...@apache.org>.
szha merged pull request #18768:
URL: https://github.com/apache/incubator-mxnet/pull/18768


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18768: Fix crash when accessing already destructed static variables

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18768:
URL: https://github.com/apache/incubator-mxnet/pull/18768#issuecomment-662163130


   Hey @ptrendx , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [edge, centos-cpu, unix-gpu, clang, windows-cpu, centos-gpu, unix-cpu, windows-gpu, website, miscellaneous, sanity]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18768: Fix crash when accessing already destructed static variables

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18768:
URL: https://github.com/apache/incubator-mxnet/pull/18768#issuecomment-682338396


   Is this commit part of the 1.7.0 release? I couldn't find it mentioned in the Release Notes: https://github.com/apache/incubator-mxnet/releases/tag/1.7.0
   
   At the very least, should we cherry-pick it into v1.x [for 1.8]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #18768: Fix crash when accessing already destructed static variables

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18768:
URL: https://github.com/apache/incubator-mxnet/pull/18768#issuecomment-662271402


   Thanks for tracking this down and for the fix, @ptrendx. Knowing the fix now, it looks so obvious with my 20/20 hindsight. 🤦‍♂️


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org