You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2024/02/05 13:13:36 UTC
[PR] Configuration typo fix [incubator-pekko]
Roiocam opened a new pull request, #1100:
URL: https://github.com/apache/incubator-pekko/pull/1100
Separate PR and cherry-pick from #1096, and solve all module typos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Configuration typo fixes [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1100:
URL: https://github.com/apache/incubator-pekko/pull/1100#discussion_r1478460086
##########
remote/src/main/resources/reference.conf:
##########
@@ -492,7 +492,7 @@ pekko {
applied-adapters = []
# The default remote server port clients should connect to.
- # Default is 7355 (PEKK on a telephone keypad), use 0 if you want a random available port
Review Comment:
Thanks, I forgot the previous discussion of pekko default listener port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Configuration typo fixes [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1100:
URL: https://github.com/apache/incubator-pekko/pull/1100#discussion_r1478461897
##########
remote/src/main/resources/reference.conf:
##########
@@ -852,7 +852,7 @@ pekko {
# collected, which is not as efficient as reusing buffers in the pool.
large-buffer-pool-size = 32
- # For enabling testing features, such as blackhole in pekko-remote-testkit.
+ # For enabling testing features, such as black-hole in pekko-remote-testkit.
Review Comment:
Yes, but I think the `black-hole` may clear that `blackhole`, Never mind, let we keep `blackhole`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Configuration typo fixes [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1100:
URL: https://github.com/apache/incubator-pekko/pull/1100#discussion_r1478375152
##########
remote/src/main/resources/reference.conf:
##########
@@ -492,7 +492,7 @@ pekko {
applied-adapters = []
# The default remote server port clients should connect to.
- # Default is 7355 (PEKK on a telephone keypad), use 0 if you want a random available port
Review Comment:
7355 is PEKK - 4 digits, 4 letters - so can you undo this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Configuration typo fixes [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1100:
URL: https://github.com/apache/incubator-pekko/pull/1100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Configuration typo fixes [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1100:
URL: https://github.com/apache/incubator-pekko/pull/1100#discussion_r1478374180
##########
cluster/src/main/resources/reference.conf:
##########
@@ -233,7 +233,7 @@ pekko {
multi-data-center {
# Defines which data center this node belongs to. It is typically used to make islands of the
- # cluster that are colocated. This can be used to make the cluster aware that it is running
+ # cluster that are collocated. This can be used to make the cluster aware that it is running
Review Comment:
the change is not wrong - should be colocated or co-located
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Configuration typo fixes [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1100:
URL: https://github.com/apache/incubator-pekko/pull/1100#discussion_r1478372316
##########
cluster-sharding/src/main/resources/reference.conf:
##########
@@ -22,7 +22,7 @@ pekko.cluster.sharding {
# When this is set to 'on' the active entity actors will automatically be restarted
# upon Shard restart. i.e. if the Shard is started on a different ShardRegion
- # due to rebalance or crash.
+ # due to rebalanced or crash.
Review Comment:
better to say `due to a rebalance event or a crash`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Configuration typo fixes [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1100:
URL: https://github.com/apache/incubator-pekko/pull/1100#discussion_r1478375830
##########
remote/src/main/resources/reference.conf:
##########
@@ -852,7 +852,7 @@ pekko {
# collected, which is not as efficient as reusing buffers in the pool.
large-buffer-pool-size = 32
- # For enabling testing features, such as blackhole in pekko-remote-testkit.
+ # For enabling testing features, such as black-hole in pekko-remote-testkit.
Review Comment:
blackhole is correct, don't change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org