You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/06/27 21:02:14 UTC

Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/
-----------------------------------------------------------

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21359
    https://issues.apache.org/jira/browse/AMBARI-21359


Repository: ambari


Description
-------

This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
  ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 


Diff: https://reviews.apache.org/r/60481/diff/1/


Testing
-------

to be tested later on with the integrated tests.


Thanks,

Di Li


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179058
-----------------------------------------------------------



just to notice this change (can be related for this): https://reviews.apache.org/r/59954/

- Oliver Szabo


On June 27, 2017, 9:02 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 9:02 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/1/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179117
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On June 28, 2017, 3:16 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 3:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/3/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179125
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Doroszlai


On June 28, 2017, 5:16 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 5:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/3/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179141
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On June 28, 2017, 11:16 a.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 11:16 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/3/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/
-----------------------------------------------------------

(Updated June 28, 2017, 3:16 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21359
    https://issues.apache.org/jira/browse/AMBARI-21359


Repository: ambari


Description
-------

This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
  ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 


Diff: https://reviews.apache.org/r/60481/diff/3/

Changes: https://reviews.apache.org/r/60481/diff/2-3/


Testing
-------

to be tested later on with the integrated tests.


Thanks,

Di Li


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Di Li <di...@ca.ibm.com>.

> On June 28, 2017, 2:45 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
> > Lines 57 (patched)
> > <https://reviews.apache.org/r/60481/diff/2/?file=1766161#file1766161line57>
> >
> >     Probably not necessary...

you are right, I removed it.


> On June 28, 2017, 2:45 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
> > Lines 64 (patched)
> > <https://reviews.apache.org/r/60481/diff/2/?file=1766161#file1766161line64>
> >
> >     Is there an extra S on the end of this?

yeah, removed it.


- Di


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179106
-----------------------------------------------------------


On June 28, 2017, 3:16 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 3:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/3/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179106
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 42 (patched)
<https://reviews.apache.org/r/60481/#comment253590>

    Is this the minimum version for Ambari? Configuration defines this differently:
    
    https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java#L180-L183
    
    Should we be using that instead?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 57 (patched)
<https://reviews.apache.org/r/60481/#comment253586>

    Probably not necessary...



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 64 (patched)
<https://reviews.apache.org/r/60481/#comment253588>

    Is there an extra S on the end of this?


- Jonathan Hurley


On June 28, 2017, 9:34 a.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 9:34 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/2/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/
-----------------------------------------------------------

(Updated June 28, 2017, 1:34 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21359
    https://issues.apache.org/jira/browse/AMBARI-21359


Repository: ambari


Description
-------

This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
  ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 


Diff: https://reviews.apache.org/r/60481/diff/2/

Changes: https://reviews.apache.org/r/60481/diff/1-2/


Testing
-------

to be tested later on with the integrated tests.


Thanks,

Di Li


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179074
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
Lines 336 (patched)
<https://reviews.apache.org/r/60481/#comment253513>

    Why put a specific version in the message here?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 34-35 (patched)
<https://reviews.apache.org/r/60481/#comment253487>

    "Hive Metastore"?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 44 (patched)
<https://reviews.apache.org/r/60481/#comment253502>

    Comment belongs to previous line, doesn't it?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 82 (patched)
<https://reviews.apache.org/r/60481/#comment253492>

    Seems to have 2 arguments for single `%s`.
    
    What does the message turn out in this case?  Isn't it something like "... requires at least JDK Java ..."?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 93 (patched)
<https://reviews.apache.org/r/60481/#comment253506>

    `javaVersionS` may be null, which shouldn't be displayed in the formatted message



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 95 (patched)
<https://reviews.apache.org/r/60481/#comment253489>

    unnecessary


- Attila Doroszlai


On June 27, 2017, 11:02 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 11:02 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/1/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179050
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On June 27, 2017, 9:02 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 9:02 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/1/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179056
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On June 27, 2017, 9:02 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 9:02 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/1/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179081
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 100-101 (patched)
<https://reviews.apache.org/r/60481/#comment253516>

    `Configuration.getJavaVersion` does not require any information from the `Configuration` instance, it only checks a system property.  Can you please make it `static` to avoid unnecessarily reading the config file?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 105 (patched)
<https://reviews.apache.org/r/60481/#comment253514>

    This method duplicates most of `Configuration.getJavaVersion`.  This duplication could be reduced by making this method `public static`, and reusing it from `Configuration`.  Ideally, put it in some utility class.


- Attila Doroszlai


On June 27, 2017, 11:02 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 11:02 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
>     https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade pack EU xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/1/
> 
> 
> Testing
> -------
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>